From: Christoph Hellwig <hch@lst.de>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: sj1557.seo@samsung.com, yuezhang.mo@sony.com, brauner@kernel.org,
djwong@kernel.org, hch@lst.de, linux-fsdevel@vger.kernel.org,
anmuxixixi@gmail.com, dxdt@dev.snart.me, chizhiling@kylinos.cn,
chizhiling@163.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 01/11] iomap: introduce IOMAP_F_ZERO_TAIL flag
Date: Fri, 15 May 2026 06:48:40 +0200 [thread overview]
Message-ID: <20260515044840.GA4059@lst.de> (raw)
In-Reply-To: <20260513112156.9122-2-linkinjeon@kernel.org>
> +++ b/fs/iomap/buffered-io.c
> @@ -837,6 +837,7 @@ static int __iomap_write_begin(const struct iomap_iter *iter,
> folio_zero_segments(folio, poff, from, to, poff + plen);
> } else {
> int status;
> + const struct iomap *iomap = iomap_iter_srcmap(iter);
Please keep variables initialized at declaration time above those that
are not.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-05-15 4:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 11:21 [PATCH v3 00/11] exfat: convert to iomap Namjae Jeon
2026-05-13 11:21 ` [PATCH v3 01/11] iomap: introduce IOMAP_F_ZERO_TAIL flag Namjae Jeon
2026-05-15 4:48 ` Christoph Hellwig [this message]
2026-05-15 5:52 ` Namjae Jeon
2026-05-13 11:21 ` [PATCH v3 02/11] exfat: replace unsafe macros with static inline functions Namjae Jeon
2026-05-13 11:21 ` [PATCH v3 03/11] exfat: add balloc parameter to exfat_map_cluster() for iomap support Namjae Jeon
2026-05-13 11:21 ` [PATCH v3 04/11] exfat: add exfat_file_open() Namjae Jeon
2026-05-13 12:06 ` CharSyam
2026-05-13 14:11 ` Namjae Jeon
2026-05-13 11:21 ` [PATCH v3 05/11] exfat: add support for multi-cluster allocation Namjae Jeon
2026-05-13 11:21 ` [PATCH v3 06/11] exfat: add data_start_bytes and exfat_cluster_to_phys() helper Namjae Jeon
2026-05-13 15:17 ` CharSyam
2026-05-13 23:43 ` Namjae Jeon
2026-05-13 11:21 ` [PATCH v3 07/11] exfat: fix implicit declaration of brelse() Namjae Jeon
2026-05-13 11:21 ` [PATCH v3 08/11] exfat: add iomap buffered I/O support Namjae Jeon
2026-05-14 1:39 ` Chi Zhiling
2026-05-14 1:47 ` Namjae Jeon
2026-05-13 11:21 ` [PATCH v3 09/11] exfat: add iomap direct " Namjae Jeon
2026-05-13 11:21 ` [PATCH v3 10/11] exfat: add support for SEEK_HOLE and SEEK_DATA in llseek Namjae Jeon
2026-05-13 11:21 ` [PATCH v3 11/11] exfat: make exfat_truncate() return error code Namjae Jeon
2026-05-15 4:50 ` [PATCH v3 00/11] exfat: convert to iomap Christoph Hellwig
2026-05-15 5:57 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515044840.GA4059@lst.de \
--to=hch@lst.de \
--cc=anmuxixixi@gmail.com \
--cc=brauner@kernel.org \
--cc=chizhiling@163.com \
--cc=chizhiling@kylinos.cn \
--cc=djwong@kernel.org \
--cc=dxdt@dev.snart.me \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=yuezhang.mo@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.