From: sashiko-bot@kernel.org
To: "Arnd Bergmann" <arnd@kernel.org>
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH] bpf: make bpf_session_cookie() reference optional
Date: Fri, 15 May 2026 09:16:07 +0000 [thread overview]
Message-ID: <20260515091607.ED08CC2BCB8@smtp.kernel.org> (raw)
In-Reply-To: <20260515090631.284426-1-arnd@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit title incorrectly states 'bpf: make bpf_session_cookie() reference optional', while the patch actually makes the `bpf_session_is_return()` reference optional.
--
commit 955fac0158a2cad097b15c2d40f2d73bdbbf8828
Author: Arnd Bergmann <arnd@arndb.de>
bpf: make bpf_session_cookie() reference optional
This commit fixes a build warning caused by an unresolved btfid symbol
when building without CONFIG_BPF_EVENTS. It wraps the function reference in
the appropriate preprocessor conditionals to match the verifier's behavior
for other conditionally built functions.
> bpf: make bpf_session_cookie() reference optional
This isn't a bug, but the commit subject mentions bpf_session_cookie(),
while the patch and the commit message body actually update the reference
for bpf_session_is_return(). Should the subject be updated to match the
function being modified?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260515090631.284426-1-arnd@kernel.org?part=1
next prev parent reply other threads:[~2026-05-15 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 9:06 [PATCH] bpf: make bpf_session_cookie() reference optional Arnd Bergmann
2026-05-15 9:16 ` sashiko-bot [this message]
2026-05-15 9:43 ` bot+bpf-ci
2026-05-19 16:18 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515091607.ED08CC2BCB8@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=arnd@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.