Re: [PATCH v4 1/2] dt-bindings: iio: adc: add support for PAC1944

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding defines GPIO controller capabilities but omits `gpio-controller` and `#gpio-cells` from the `required` list and `examples` block.
--

commit a57d647e4dad8345f6c818b69281dba50b43a7f4
Author: Marius Cristea <marius.cristea@microchip.com>

dt-bindings: iio: adc: add support for PAC1944

This commit introduces the device tree schema for the Microchip PAC194X
and PAC195X series of Power Monitors with Accumulator. It covers variants
for high-side and low-side current sensing or floating VBUS applications.

> diff --git a/Documentation/devicetree/bindings/iio/adc/microchip,pac1944.yaml b/Documentation/devicetree/bindings/iio/adc/microchip,pac1944.yaml
> new file mode 100644
> index 0000000000000..eca1b25f038be
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/microchip,pac1944.yaml
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +  - "#address-cells"
> +  - "#size-cells"

Should `gpio-controller` and `#gpio-cells` be added to this `required` list?

According to the dt-bindings guidelines, when a binding defines hardware
provider capabilities such as a GPIO controller, the standard properties
should be explicitly required to prevent incomplete device tree nodes from
passing schema validation.

[ ... ]
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        power-monitor@10 {
> +            compatible = "microchip,pac1954";
> +            reg = <0x10>;
> +            vdd-supply = <&vdd>;
> +
> +            #address-cells = <1>;
> +            #size-cells = <0>;

Should `gpio-controller` and `#gpio-cells` also be included in this example
block?

If they are added to the required properties list, omitting them from the
examples section might cause dt_binding_check to fail.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515092946.10791-1-marius.cristea@microchip.com?part=1