Re: [PATCH v3 2/3] dt-bindings: pinctrl: Add aspeed,ast2700-soc1-pinctrl

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Schema uses `additionalProperties: false` alongside `$ref` instead of `unevaluatedProperties: false`.
--

commit f22ff0791aac86f631d0cc5f4662941db457d162
Author: Billy Tsai <billy_tsai@aspeedtech.com>

dt-bindings: pinctrl: Add aspeed,ast2700-soc1-pinctrl

This commit introduces a new devicetree binding schema for the ASPEED
AST2700 SoC1 pin controller. It reuses the standard pinmux and generic
pin configuration schemas.

> diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2700-soc1-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2700-soc1-pinctrl.yaml
> new file mode 100644
> index 0000000000000..76944fd14e2c7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2700-soc1-pinctrl.yaml
> @@ -0,0 +1,760 @@

[ ... ]

> +patternProperties:
> +  '-state$':
> +    description: |
> +      Pin control state.

[ ... ]

> +    type: object
> +    allOf:
> +      - $ref: pinmux-node.yaml#
> +      - $ref: pincfg-node.yaml#

[ ... ]

> +              - pins
> +    additionalProperties: false

Since this block references pinmux-node.yaml and pincfg-node.yaml, should
this use unevaluatedProperties: false instead? Using additionalProperties:
false might cause standard properties provided by the referenced schemas to
be incorrectly rejected during validation.

> +
> +    properties:
> +      function:

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +
> +allOf:
> +  - $ref: pinctrl.yaml#
> +
> +additionalProperties: false

Similarly, since the root level includes a reference to pinctrl.yaml, does
this also need to be unevaluatedProperties: false?

> +
> +examples:
> +  - |

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515-pinctrl-single-bit-v3-0-e97da4312104@aspeedtech.com?part=2