From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6BD4CD343F for ; Fri, 15 May 2026 11:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KkIMNUfdwTYHivTJYpDbYfo5Zwu9LfaQu6iHl7B8kVg=; b=BIElgtk0Xlh6q6 YVndfV+0Hf/cEBtvapW2SGCyHcnTVnzosjr/peU19lShVMO5qEgWYgGimU0Tv3mo97F4q4tv3pG2+ mo02dAHZFp3ebruZV0zpb3Kfpl2fdhSqu8jPpN1C7kYvsaJrLQAd598zY6TBk2+wDBN2M9mejH7LH K7egiwMGzzDjKB4shiCyaHrWjgFMc4tdpSkomxfkilTsHYGXxFoI3mnRlHmEjjb6qhLCQ4PskiKwE j0DoQ1Y0lkj06E9s4l/ihmMsHEpwLjUD0XVDecn2GUfB2EzirrCi8eIYoQ+8wapg1KUBBdzmy7Gm1 YAAGikh4+al2DEmK09pA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNqd5-00000008AhJ-2bYN; Fri, 15 May 2026 11:22:55 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNqd4-00000008Ah1-35st for linux-phy@lists.infradead.org; Fri, 15 May 2026 11:22:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 90FE060008; Fri, 15 May 2026 11:22:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E684CC2BCB0; Fri, 15 May 2026 11:22:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778844173; bh=n6vPndmDX81xjEhOctO+/4d40aylt23r+5ajLWjHvjM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=WBo0Ss/XmvtavW47WP4VGnic8gNk8banDFM+JPa/ee5RZuveQjIgyrQd+VBZCuyrI lP0uSkJAPtRRStU6nxACAZcdi3394Cn1nXl9JlnYa/zHLgi8GWVI4OWF4I4U4zcfs8 La756hyaj5XVNAPJHcd1cSzFs7fxrHG4vzXOzAPlfpUtOROgcV6EvfovVjZkD9eAdu AE+sOC5Ycz+hNAuQWF/MghtbLxsxEAuOwAdtk8XUoZ1l/TnmqDuzeFJ9bFVPE/uDKj lJhHBrh4VDSC6+CsR+9BUAsEuLV/kwC3zSwsISPWMblZJi7ftiL3Lp99H/2XUwhX/l C1eCVCUQfWYEw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 phy-next 2/2] phy: ti: add PHY driver for TI DS125DF111 Dual-Channel Retimer To: "Ioana Ciornei" Cc: conor+dt@kernel.org, krzk+dt@kernel.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, olteanv@gmail.com, neil.armstrong@linaro.org, vkoul@kernel.org, robh@kernel.org In-Reply-To: <20260515110145.1925579-3-ioana.ciornei@nxp.com> References: <20260515110145.1925579-3-ioana.ciornei@nxp.com> Date: Fri, 15 May 2026 11:22:52 +0000 Message-Id: <20260515112252.E684CC2BCB0@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIE1pc3NpbmcgZGVsYXkg b3IgcG9sbGluZyBhZnRlciBzZXR0aW5nIGEgc2VsZi1jbGVhcmluZyBoYXJkd2FyZSByZXNldCBi aXQuCi0tCgpjb21taXQgNTlhNWNhNzQxMTMwOGE4MWMxNDZkNjYwYjhjMDRlMGJlOGZlOGZiYgpB dXRob3I6IElvYW5hIENpb3JuZWkgPGlvYW5hLmNpb3JuZWlAbnhwLmNvbT4KCnBoeTogdGk6IGFk ZCBQSFkgZHJpdmVyIGZvciBUSSBEUzEyNURGMTExIER1YWwtQ2hhbm5lbCBSZXRpbWVyCgpUaGlz IGNvbW1pdCBhZGRzIGEgZ2VuZXJpYyBQSFkgZHJpdmVyIGZvciB0aGUgVEkgRFMxMjVERjExMSBN dWx0aS1Qcm90b2NvbApEdWFsLUNoYW5uZWwgUmV0aW1lci4gSXQgc3VwcG9ydHMgMTBHIGFuZCAx RyBsaW5rIHNwZWVkcywgbW9kZWxpbmcgZWFjaCBvZgp0aGUgdHdvIGNoYW5uZWxzIGFzIGEgc2Vw YXJhdGUgUEhZIGRldmljZS4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L3RpL3BoeS1kczEy NWRmMTExLmMgYi9kcml2ZXJzL3BoeS90aS9waHktZHMxMjVkZjExMS5jCj4gbmV3IGZpbGUgbW9k ZSAxMDA2NDQKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvZHJpdmVycy9waHkvdGkvcGh5LWRzMTI1 ZGYxMTEuYwoKWyAuLi4gXQoKPiArc3RhdGljIGludCBkczEyNWRmMTExX2NvbmZpZ3VyZShzdHJ1 Y3QgcGh5ICpwaHksCj4gKwkJCQljb25zdCBzdHJ1Y3QgZHMxMjVkZjExMV9jb25maWcgKmNmZykK PiArewoKWyAuLi4gXQoKPiArCS8qIFJlc2V0IENoYW5uZWwgUmVnaXN0ZXJzICovCj4gKwllcnIg PSBpMmNfc21idXNfcmVhZF9ieXRlX2RhdGEoaTJjLCBEUzEyNURGMTExX0NIX0NUUkwpOwo+ICsJ aWYgKGVyciA8IDApIHsKPiArCQlkZXZfZXJyKGRldiwgIkVycm9yIHJlc2V0dGluZyBjaGFubmVs IGNvbmZpZ3VyYXRpb25cbiIpOwo+ICsJCWdvdG8gb3V0Owo+ICsJfQo+ICsJdmFsID0gKHU4KWVy cjsKPiArCXZhbCB8PSBEUzEyNURGMTExX0NIX0NUUkxfUkVTRVQ7Cj4gKwllcnIgPSBpMmNfc21i dXNfd3JpdGVfYnl0ZV9kYXRhKGkyYywgRFMxMjVERjExMV9DSF9DVFJMLCB2YWwpOwo+ICsJaWYg KGVyciA8IDApIHsKPiArCQlkZXZfZXJyKGRldiwgIkVycm9yIHJlc2V0dGluZyBjaGFubmVsIGNv bmZpZ3VyYXRpb25cbiIpOwo+ICsJCWdvdG8gb3V0Owo+ICsJfQo+ICsKPiArCS8qIFByb2dyYW0g dGhlIFZDTyBncm91cCBmcmVxdWVuY2llcyAqLwo+ICsJZm9yIChpID0gMDsgaSA8IERTMTI1REYx MTFfTlVNX1ZDT19HUk9VUF9SRUc7IGkrKykgewo+ICsJCWVyciA9IGkyY19zbWJ1c193cml0ZV9i eXRlX2RhdGEoaTJjLAo+ICsJCQkJCQlEUzEyNURGMTExX1ZDT19HUk9VUF9CQVNFICsgaSwKPiAr CQkJCQkJY2ZnLT52Y29fZ3JvdXBbaV0pOwoKSXMgYSBkZWxheSBvciBwb2xsaW5nIGxvb3AgbmVl ZGVkIGFmdGVyIHRyaWdnZXJpbmcgdGhlIGNoYW5uZWwgcmVzZXQ/CgpUaGUgRFMxMjVERjExMV9D SF9DVFJMX1JFU0VUIGJpdCBpcyBkZWZpbmVkIGFzIHNlbGYtY2xlYXJpbmcsIGJ1dCB0aGUgY29k ZSAKaW1tZWRpYXRlbHkgcHJvY2VlZHMgdG8gcHJvZ3JhbSB0aGUgVkNPIGdyb3VwIGZyZXF1ZW5j aWVzIHdpdGhvdXQgY2hlY2tpbmcgaWYKdGhlIHJlc2V0IGhhcyBmaW5pc2hlZC4KClNpbmNlIGhh cmR3YXJlIHJlc2V0cyB1c3VhbGx5IHRha2UgYSBub24temVybyBhbW91bnQgb2YgdGltZSwgd3Jp dGluZyB0byB0aGUKcmVnaXN0ZXJzIHJpZ2h0IGF3YXkgY291bGQgcmVzdWx0IGluIHRoZSBkZXZp Y2UgTkFDS2luZyB0aGUgdHJhbnNhY3Rpb25zIG9yCnNpbGVudGx5IGRyb3BwaW5nIHRoZSBuZXcg Y29uZmlndXJhdGlvbi4KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28u ZGV2LyMvcGF0Y2hzZXQvMjAyNjA1MTUxMTAxNDUuMTkyNTU3OS0xLWlvYW5hLmNpb3JuZWlAbnhw LmNvbT9wYXJ0PTIKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9161E45BD57 for ; Fri, 15 May 2026 11:22:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778844173; cv=none; b=QlaWmPSZjk44KIWbVnUyNqv+Zn25xxIP5zXdikSh2HJ5c98JpJXicoFlDjVsWFhvUutlZBPObvhh2y7pgUWsoO2B2RnoMrf/YU79abvlVKt0UI07IyNOmQfAyF8/rxGI3MloviKL7FDxVIWpdxk+Ow1aXme1P3thAehhw1X2cKc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778844173; c=relaxed/simple; bh=n6vPndmDX81xjEhOctO+/4d40aylt23r+5ajLWjHvjM=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=oFQpUSXiSIezOtq3lSalcLTeSZU2zk3wBfVpXTt688y13GloSeqAet2UzXeh0JHjZ/dJig70z9fnCmtpgOkXXfBsf+sjDzc0fHhCHm/EimoiEEkl3YUmH3FmDJoWl7i9EbihRu1ObW+Prgo6MlUu1RvjnyK23loPymZV6yaETFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WBo0Ss/X; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WBo0Ss/X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E684CC2BCB0; Fri, 15 May 2026 11:22:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778844173; bh=n6vPndmDX81xjEhOctO+/4d40aylt23r+5ajLWjHvjM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=WBo0Ss/XmvtavW47WP4VGnic8gNk8banDFM+JPa/ee5RZuveQjIgyrQd+VBZCuyrI lP0uSkJAPtRRStU6nxACAZcdi3394Cn1nXl9JlnYa/zHLgi8GWVI4OWF4I4U4zcfs8 La756hyaj5XVNAPJHcd1cSzFs7fxrHG4vzXOzAPlfpUtOROgcV6EvfovVjZkD9eAdu AE+sOC5Ycz+hNAuQWF/MghtbLxsxEAuOwAdtk8XUoZ1l/TnmqDuzeFJ9bFVPE/uDKj lJhHBrh4VDSC6+CsR+9BUAsEuLV/kwC3zSwsISPWMblZJi7ftiL3Lp99H/2XUwhX/l C1eCVCUQfWYEw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 phy-next 2/2] phy: ti: add PHY driver for TI DS125DF111 Dual-Channel Retimer Reply-To: sashiko-reviews@lists.linux.dev To: "Ioana Ciornei" Cc: conor+dt@kernel.org, krzk+dt@kernel.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, olteanv@gmail.com, neil.armstrong@linaro.org, vkoul@kernel.org, robh@kernel.org In-Reply-To: <20260515110145.1925579-3-ioana.ciornei@nxp.com> References: <20260515110145.1925579-3-ioana.ciornei@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 15 May 2026 11:22:52 +0000 Message-Id: <20260515112252.E684CC2BCB0@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] Missing delay or polling after setting a self-clearing hardware re= set bit. -- commit 59a5ca7411308a81c146d660b8c04e0be8fe8fbb Author: Ioana Ciornei phy: ti: add PHY driver for TI DS125DF111 Dual-Channel Retimer This commit adds a generic PHY driver for the TI DS125DF111 Multi-Protocol Dual-Channel Retimer. It supports 10G and 1G link speeds, modeling each of the two channels as a separate PHY device. > diff --git a/drivers/phy/ti/phy-ds125df111.c b/drivers/phy/ti/phy-ds125df= 111.c > new file mode 100644 > --- /dev/null > +++ b/drivers/phy/ti/phy-ds125df111.c [ ... ] > +static int ds125df111_configure(struct phy *phy, > + const struct ds125df111_config *cfg) > +{ [ ... ] > + /* Reset Channel Registers */ > + err =3D i2c_smbus_read_byte_data(i2c, DS125DF111_CH_CTRL); > + if (err < 0) { > + dev_err(dev, "Error resetting channel configuration\n"); > + goto out; > + } > + val =3D (u8)err; > + val |=3D DS125DF111_CH_CTRL_RESET; > + err =3D i2c_smbus_write_byte_data(i2c, DS125DF111_CH_CTRL, val); > + if (err < 0) { > + dev_err(dev, "Error resetting channel configuration\n"); > + goto out; > + } > + > + /* Program the VCO group frequencies */ > + for (i =3D 0; i < DS125DF111_NUM_VCO_GROUP_REG; i++) { > + err =3D i2c_smbus_write_byte_data(i2c, > + DS125DF111_VCO_GROUP_BASE + i, > + cfg->vco_group[i]); Is a delay or polling loop needed after triggering the channel reset? The DS125DF111_CH_CTRL_RESET bit is defined as self-clearing, but the code= =20 immediately proceeds to program the VCO group frequencies without checking = if the reset has finished. Since hardware resets usually take a non-zero amount of time, writing to the registers right away could result in the device NACKing the transactions or silently dropping the new configuration. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260515110145.1925= 579-1-ioana.ciornei@nxp.com?part=3D2