From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06A4BCD4851 for ; Fri, 15 May 2026 11:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=boUk9T/A5E6hGWWFwYgu664E3lmiNhJpKwdGO1blliw=; b=KPKZhIt4InV+Rx xAmo55WYEB9HmL8m1rPOzphXOJu8XwW5TwwSn8cG83q/Zqw7609ncfKxnlt5OM43y1UWnwaC5Ni0y GxsjkotX3YF67SIjNycLoT/fh0+8rvEw1tLFpOle5vkmzRV8BgosmRFnhuzts8/yxV3sn0nK/uX59 M3XEQgL/xPU0gpWK2+6ZzI8FEHw0xZjI19Y1wc/2aYa1m/l9Mooz+25cYXJxoVaFEybyk2jMxZpg9 lWBogxmrGG6wPfavFaB5g8AJMwLqv+qrR6959PWfjucCCKJw+/tBsNpcP8PG4K7cTyK2s1TK6c5eT +wq8tYS+UtV1B8OHiZeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNqiD-00000008Bn3-2cpL; Fri, 15 May 2026 11:28:13 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wNqiA-00000008Blw-3FFP for linux-phy@lists.infradead.org; Fri, 15 May 2026 11:28:12 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 68D4B40ACC; Fri, 15 May 2026 11:28:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE5B9C2BCB0; Fri, 15 May 2026 11:28:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778844490; bh=PFdzFQ8z12U6QPw7WHvmKcX4PQwoOiB5fLp7t21R8Oc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=Zr6O/ILV7VkYwK9nnpIpUHLLpe1mLXoE09pG2UsQp1Fh884GLZ74kqg0cjqUBLTsB cn5DLO52WcgGQViaTFqk9rBS1jAwK+JFhaPA9UwgSKatv1/B6H1kaFIdq3HI089vJf 0J8G92wlqkW7i7d0RtlGsYQdeh3SdJpCrt2ICThau18h2mqxVYqx1lu+FhGojr+pMx OrqR6HY8/XXuTad2NaHCc6FQNZpwYAAi+k99N4H1+dgE4AHZJML8R5j3Cy00M/rlMK JxLr9Et3euSBXe8agTehCq/uNcZfIU9mZ/edvFLY3ysqPK7KYrCmhCVFHocacQoF5a ujW+wKsYXdRSQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH 5/5] phy: qcom-qusb2: add QUSB2 support for ipq5210 To: "Varadarajan Narayanan" Cc: linux-phy@lists.infradead.org, vkoul@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com, robh@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260515-usb2phy-v1-5-5f8338d466bf@oss.qualcomm.com> References: <20260515-usb2phy-v1-5-5f8338d466bf@oss.qualcomm.com> Date: Fri, 15 May 2026 11:28:09 +0000 Message-Id: <20260515112809.EE5B9C2BCB0@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260515_042810_838113_0AAFE85F X-CRM114-Status: UNSURE ( 8.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gVGhlIGNvbW1pdCBt ZXNzYWdlIGluY29ycmVjdGx5IGRlc2NyaWJlcyB0aGUgcGF0Y2ggY29udGVudHMuIEl0IGNsYWlt cyB0byBhZGQgYW4gaW5pdCBzZXF1ZW5jZSBmb3IgJ1N1cGVyIFNwZWVkIHBvcnRzJywgYnV0IHRo ZSBwYXRjaCBhY3R1YWxseSBtb2RpZmllcyB0aGUgUVVTQjIgUEhZIGRyaXZlciwgd2hpY2ggaXMg cmVzcG9uc2libGUgZm9yIFVTQiAyLjAgKEhpZ2ggU3BlZWQgLyBGdWxsIFNwZWVkIC8gTG93IFNw ZWVkKSBwb3J0cy4gRnVydGhlcm1vcmUsIHRoZSBwYXRjaCBkb2VzIG5vdCBpbnRyb2R1Y2UgYSBu ZXcgaW5pdGlhbGl6YXRpb24gc2VxdWVuY2U7IGl0IHNpbXBseSBtYXBzIHRoZSBuZXcgYHFjb20s aXBxNTIxMC1xdXNiMi1waHlgIGNvbXBhdGlibGUgc3RyaW5nIHRvIHRoZSBleGlzdGluZyBgaXBx NjAxOF9waHlfY2ZnYCBkYXRhLgotLQoKY29tbWl0IGEzMjcwNTVhZjA5YTE1MjBjZjhmODg3MzVi MTEwZjFkZjc2NzRlNjQKQXV0aG9yOiBWYXJhZGFyYWphbiBOYXJheWFuYW4gPHZhcmFkYXJhamFu Lm5hcmF5YW5hbkBvc3MucXVhbGNvbW0uY29tPgoKcGh5OiBxY29tLXF1c2IyOiBhZGQgUVVTQjIg c3VwcG9ydCBmb3IgaXBxNTIxMAoKVGhpcyBjb21taXQgYWRkcyBhIG5ldyBjb21wYXRpYmxlIHN0 cmluZyBmb3IgdGhlIElQUTUyMTAgU29DIHRvIHRoZSBRVVNCMgpQSFkgZHJpdmVyLiBJdCBtYXBz IHRoZSBuZXcgY29tcGF0aWJsZSBzdHJpbmcgdG8gdGhlIGV4aXN0aW5nCmlwcTYwMThfcGh5X2Nm ZyBkYXRhIHN0cnVjdHVyZS4KCj4gQWRkIHRoZSBwaHkgaW5pdCBzZXF1ZW5jZSBmb3IgdGhlIFN1 cGVyIFNwZWVkIHBvcnRzIGZvdW5kCj4gb24gaXBxNTIxMC4KCkRvZXMgdGhpcyBjb21taXQgbWVz c2FnZSBhY2N1cmF0ZWx5IGRlc2NyaWJlIHRoZSBwYXRjaCBjb250ZW50cz8KClRoZSBRVVNCMiBQ SFkgZHJpdmVyIGlzIHJlc3BvbnNpYmxlIGZvciBVU0IgMi4wIHBvcnRzLCByYXRoZXIgdGhhbiBT dXBlcgpTcGVlZCBwb3J0cy4gQWRkaXRpb25hbGx5LCB0aGUgcGF0Y2ggbWFwcyB0aGUgY29tcGF0 aWJsZSBzdHJpbmcgdG8gdGhlCmV4aXN0aW5nIGlwcTYwMThfcGh5X2NmZyBkYXRhIGluc3RlYWQg b2YgYWRkaW5nIGEgbmV3IGluaXRpYWxpemF0aW9uCnNlcXVlbmNlLgoKQ291bGQgdGhlIGNvbW1p dCBtZXNzYWdlIGJlIHVwZGF0ZWQgdG8gcmVmbGVjdCB0aGF0IGl0IGFkZHMgVVNCIDIuMCBQSFkK c3VwcG9ydD8KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMv cGF0Y2hzZXQvMjAyNjA1MTUtdXNiMnBoeS12MS0wLTVmODMzOGQ0NjZiZkBvc3MucXVhbGNvbW0u Y29tP3BhcnQ9NQoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7FAC47DF8A for ; Fri, 15 May 2026 11:28:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778844490; cv=none; b=HvieCTt1ifsQ6SpmyHujE11mKJjL3wSXeXhuz5yzy8V7uBKv8uqeRjkR3l42Ah7GlOXZ/Kox8W8jYk6b5Pt14G1d2Ro2+5qmFsUjo7beRxeS5jnE108z4cPt/xVyfiPA0uTpakP+pvD1UWQnK59dHZE1hYE1kaIr1DID/cew1Nw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778844490; c=relaxed/simple; bh=PFdzFQ8z12U6QPw7WHvmKcX4PQwoOiB5fLp7t21R8Oc=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=D2Mo0JoYviQPHLzjYGi1rleBdp+zfy0ompvHT/1ITeINq+LExn+RZ5mC6ukAoX21w2029ryYBafH3v0NcAoNdXHmSlk8PMKoc1zjBWwvg6wkDFJAWC+/jOY0pLVy+FhjvcAsdgnkDZXCXBpReYPFM0CyNA0XO1JqWrGD/0JCmw0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Zr6O/ILV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Zr6O/ILV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE5B9C2BCB0; Fri, 15 May 2026 11:28:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778844490; bh=PFdzFQ8z12U6QPw7WHvmKcX4PQwoOiB5fLp7t21R8Oc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=Zr6O/ILV7VkYwK9nnpIpUHLLpe1mLXoE09pG2UsQp1Fh884GLZ74kqg0cjqUBLTsB cn5DLO52WcgGQViaTFqk9rBS1jAwK+JFhaPA9UwgSKatv1/B6H1kaFIdq3HI089vJf 0J8G92wlqkW7i7d0RtlGsYQdeh3SdJpCrt2ICThau18h2mqxVYqx1lu+FhGojr+pMx OrqR6HY8/XXuTad2NaHCc6FQNZpwYAAi+k99N4H1+dgE4AHZJML8R5j3Cy00M/rlMK JxLr9Et3euSBXe8agTehCq/uNcZfIU9mZ/edvFLY3ysqPK7KYrCmhCVFHocacQoF5a ujW+wKsYXdRSQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH 5/5] phy: qcom-qusb2: add QUSB2 support for ipq5210 Reply-To: sashiko-reviews@lists.linux.dev To: "Varadarajan Narayanan" Cc: linux-phy@lists.infradead.org, vkoul@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com, robh@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260515-usb2phy-v1-5-5f8338d466bf@oss.qualcomm.com> References: <20260515-usb2phy-v1-5-5f8338d466bf@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 15 May 2026 11:28:09 +0000 Message-Id: <20260515112809.EE5B9C2BCB0@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The commit message incorrectly describes the patch contents. It = claims to add an init sequence for 'Super Speed ports', but the patch actua= lly modifies the QUSB2 PHY driver, which is responsible for USB 2.0 (High S= peed / Full Speed / Low Speed) ports. Furthermore, the patch does not intro= duce a new initialization sequence; it simply maps the new `qcom,ipq5210-qu= sb2-phy` compatible string to the existing `ipq6018_phy_cfg` data. -- commit a327055af09a1520cf8f88735b110f1df7674e64 Author: Varadarajan Narayanan phy: qcom-qusb2: add QUSB2 support for ipq5210 This commit adds a new compatible string for the IPQ5210 SoC to the QUSB2 PHY driver. It maps the new compatible string to the existing ipq6018_phy_cfg data structure. > Add the phy init sequence for the Super Speed ports found > on ipq5210. Does this commit message accurately describe the patch contents? The QUSB2 PHY driver is responsible for USB 2.0 ports, rather than Super Speed ports. Additionally, the patch maps the compatible string to the existing ipq6018_phy_cfg data instead of adding a new initialization sequence. Could the commit message be updated to reflect that it adds USB 2.0 PHY support? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260515-usb2phy-v1= -0-5f8338d466bf@oss.qualcomm.com?part=3D5