Re: [PATCH v11 1/6] dt-bindings: iio: adc: add AD4691 family

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding defines GPIO controller capabilities but omits `gpio-controller` and `#gpio-cells` from the `required` list and the `examples` section.
--

commit 5576d49868d1ae53d794381f2b3e2079954441db
Author: Radu Sabau <radu.sabau@analog.com>

dt-bindings: iio: adc: add AD4691 family

This commit adds device tree bindings for the Analog Devices AD4691 family
of multichannel SAR ADCs. It defines hardware connections including power
domains, PWM, reset GPIOs, and interrupt sources, along with providing
two binding examples.

> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml
> new file mode 100644
> index 0000000000000..af28a0c1cfa9e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml

[ ... ]

> +  gpio-controller: true
> +
> +  '#gpio-cells':
> +    const: 2
> +
> +  '#trigger-source-cells':
> +    description:
> +      This node can act as a trigger source. The single cell in a consumer
> +      reference specifies the GP pin number (0-3) used as the trigger output.
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - avdd-supply
> +  - vio-supply

Since the binding defines the device as a GPIO controller, should
gpio-controller and #gpio-cells be added to this required list?

Omitting these properties from the required list might allow incomplete
device tree nodes to pass validation.

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    /* AD4692 in CNV Burst Mode with SPI offload */
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@0 {
> +            compatible = "adi,ad4692";
> +            reg = <0>;
> +            spi-cpol;
> +            spi-cpha;
> +            spi-max-frequency = <40000000>;
> +
> +            avdd-supply = <&avdd_supply>;
> +            ldo-in-supply = <&avdd_supply>;
> +            vio-supply = <&vio_supply>;
> +            ref-supply = <&ref_5v>;
> +
> +            reset-gpios = <&gpio0 15 GPIO_ACTIVE_LOW>;
> +
> +            pwms = <&pwm_gen 0 0>;
> +
> +            #trigger-source-cells = <1>;
> +        };
> +    };

Should the gpio-controller and #gpio-cells properties be included in these
examples?

Without them, the examples might fail dt_binding_check if they are added
to the required list above.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515-ad4692-multichannel-sar-adc-driver-v11-0-eab27d852ac2@analog.com?part=1