Re: [kdave-btrfs-devel:ext/dv/fscrypt 32/43] fs/btrfs/fscrypt.c:240:34: sparse: sparse: incorrect type in return expression (different base types)

[David Sterba <dsterba@suse.cz>]

On Thu, May 14, 2026 at 05:53:48PM +0200, Daniel Vacek wrote:
> On Thu, 14 May 2026 at 03:51, kernel test robot <lkp@intel.com> wrote:
> >
> > tree:   https://github.com/kdave/btrfs-devel.git ext/dv/fscrypt
> > head:   4c05f02641d57f578a685f7e8d27b9cb18d17cc7
> > commit: fda37caa264ff597b0fc03039dc95e392432bbc5 [32/43] btrfs: implement process_bio cb for fscrypt
> > config: alpha-randconfig-r122-20260514 (https://download.01.org/0day-ci/archive/20260514/202605140957.DjseWRNF-lkp@intel.com/config)
> > compiler: alpha-linux-gcc (GCC) 8.5.0
> > sparse: v0.6.5-rc1
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260514/202605140957.DjseWRNF-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202605140957.DjseWRNF-lkp@intel.com/
> >
> > sparse warnings: (new ones prefixed by >>)
> > >> fs/btrfs/fscrypt.c:240:34: sparse: sparse: incorrect type in return expression (different base types) @@     expected restricted blk_status_t @@     got int @@
> >    fs/btrfs/fscrypt.c:240:34: sparse:     expected restricted blk_status_t
> >    fs/btrfs/fscrypt.c:240:34: sparse:     got int
> 
> @@ -238,7 +238,7 @@ static blk_status_t
> btrfs_process_encrypted_bio(struct bio *orig_bio,
>          ASSERT(orig_bio == enc_bio);
>          return btrfs_check_encrypted_read_bio(bbio, enc_bio);
>      }
> -    return btrfs_csum_one_bio(bbio, enc_bio, false);
> +    return btrfs_csum_one_bio(bbio, enc_bio, false)? BLK_STS_IOERR: BLK_STS_OK;
>  }
> 
> This should do the trick.

Please use errno_to_blk_status() as btrfs_csum_one_bio() can also return
-ENOMEM, which is BLK_STS_RESOURCE.