From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF2193E00A2; Fri, 15 May 2026 16:07:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861268; cv=none; b=IqU0etOFuHuEGOB3YE8DRpgE3TCtFMwtpa8FHFlur0v/99rHJRT7SpxNo8tcG37MFIpOLCl6wYMiuWqn+ByevRxDsbQrNF+TB1Yp2v1Rg3TN61l5TGu0/TBrEYnDxscQBOjcEHlhxGTO42T36kXhYzU4xdJFAhO3e1tmi0uuye8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861268; c=relaxed/simple; bh=XjlbVwBd/GCIiwSBaezMMv6r/+2tdAq9DIsU4zuTRa8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=n4UCDvJUtdyCuPc1UzMPVtadSReqtt37Vkv4mXnohQw8BERFeyEEUBUD3Ft1ZmoYhdUcI0sjnvFC3uxa8XDGvZP3e7yCXHyWiZYp481yJ6ZIk0Mj/F/NI5GNdg1qaiz/ErpA1ohOhyV7S8Vum4f98pzMnAH1trqesweULbKIZsk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zyugSkwT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zyugSkwT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86682C2BCB0; Fri, 15 May 2026 16:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778861267; bh=XjlbVwBd/GCIiwSBaezMMv6r/+2tdAq9DIsU4zuTRa8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zyugSkwTMj+GaDDKF5V2fo8zHnbm73T8EdgXPC5OlvLiFGYTmFPzQ8gT/bC0xGpVA 7+HegXGzfQJ6CKdiAXNTPLb1QVQAI1J6YXPJVw9FD+JAeDTbu/qhQtGVFhP7owouDV cEQByT3+diQIdSlbB26jYopWtl5945yLrzvB9YOw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?C=C3=A1ssio=20Gabriel?= , Cezary Rojewski , Hans de Goede , Mark Brown Subject: [PATCH 6.6 246/474] ASoC: Intel: bytcr_wm5102: Fix MCLK leak on platform_clock_control error Date: Fri, 15 May 2026 17:45:55 +0200 Message-ID: <20260515154720.322089101@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260515154715.053014143@linuxfoundation.org> References: <20260515154715.053014143@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cássio Gabriel commit 13d30682e8dee191ac04e93642f0372a723e8b0c upstream. If byt_wm5102_prepare_and_enable_pll1() fails in the SND_SOC_DAPM_EVENT_ON() path, platform_clock_control() returns after clk_prepare_enable(priv->mclk) without disabling the clock again. This leaks an MCLK enable reference on failed power-up attempts. Add the missing clk_disable_unprepare() on the error path, matching the unwind used by the other Intel platform_clock_control() implementations. Fixes: 9a87fc1e0619 ("ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102") Cc: stable@vger.kernel.org Signed-off-by: Cássio Gabriel Reviewed-by: Cezary Rojewski Reviewed-by: Hans de Goede Link: https://patch.msgid.link/20260427-bytcr-wm5102-mclk-leak-v1-1-02b96d08e99c@gmail.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/intel/boards/bytcr_wm5102.c | 1 + 1 file changed, 1 insertion(+) --- a/sound/soc/intel/boards/bytcr_wm5102.c +++ b/sound/soc/intel/boards/bytcr_wm5102.c @@ -111,6 +111,7 @@ static int platform_clock_control(struct ret = byt_wm5102_prepare_and_enable_pll1(codec_dai, 48000); if (ret) { dev_err(card->dev, "Error setting codec sysclk: %d\n", ret); + clk_disable_unprepare(priv->mclk); return ret; } } else {