From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 267423FD97E; Fri, 15 May 2026 16:09:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861392; cv=none; b=YcWPyxMYRkwAavE+KdMNhc2qCmNWpCb1vCpFkQoO2zoZTU+v7eDwOhM6TJOw+Z/Eu3T388Bulbtv0Qx5NdEqTz8BdsgGV2gzegT1ZcQ0iJ2Uvx56hcjX50nskKCdeKgpkW8EVUTHCRT5E54m63Hyh2vaGbAYZbKYNqPbe+ZqoyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861392; c=relaxed/simple; bh=T8C2l0z+dGNT9XXzLsq/xhd19KoienjlyGARPS1fovk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W85KIKfsyOrIucrttqg62CDzQwBPtmSWya0boXA45rSfYmD1OIdQ9fEDFBT/3BQKdLRXUUGCpM65N44Zpw9hXUabKV8SJRJyrjaf3DnlT5Kx3LurJ4+ogKIvnXv2C2+2xYaUJxYtggw49EzScsLkAIJPHOdpBxAHaTRq4TFbdM8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IzV2XxUe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IzV2XxUe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8628C2BCB0; Fri, 15 May 2026 16:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778861392; bh=T8C2l0z+dGNT9XXzLsq/xhd19KoienjlyGARPS1fovk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IzV2XxUe63whv1nq4c0ESbWLySpJcWa6EMVcgzqCwfNgRgxRrUkqXgMJ+6y16QUtl IYt5au9Wkw+CpZMX1sD4h7GkQ+uuy1/Yn0xoI0dmvq7e9xTPFmOStJ/a0dwLg90nXO HcBFk368k0VSrnHS1FR4Hm6/iCp3RSZ2fZCxe5Kc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hauke Mehrtens , Johan Hovold , Mark Brown Subject: [PATCH 6.6 311/474] spi: lantiq-ssc: fix controller deregistration Date: Fri, 15 May 2026 17:47:00 +0200 Message-ID: <20260515154721.737641569@linuxfoundation.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260515154715.053014143@linuxfoundation.org> References: <20260515154715.053014143@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit b99206710d032c16b7f8b75e4bc18414d8e4b9f4 upstream. Make sure to deregister the controller before releasing underlying resources like clocks during driver unbind. Fixes: 17f84b793c01 ("spi: lantiq-ssc: add support for Lantiq SSC SPI controller") Cc: stable@vger.kernel.org # 4.11 Cc: Hauke Mehrtens Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20260409120419.388546-17-johan@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi-lantiq-ssc.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/drivers/spi/spi-lantiq-ssc.c +++ b/drivers/spi/spi-lantiq-ssc.c @@ -998,7 +998,7 @@ static int lantiq_ssc_probe(struct platf "Lantiq SSC SPI controller (Rev %i, TXFS %u, RXFS %u, DMA %u)\n", revision, spi->tx_fifo_size, spi->rx_fifo_size, supports_dma); - err = devm_spi_register_controller(dev, host); + err = spi_register_controller(host); if (err) { dev_err(dev, "failed to register spi host\n"); goto err_wq_destroy; @@ -1022,6 +1022,10 @@ static void lantiq_ssc_remove(struct pla { struct lantiq_ssc_spi *spi = platform_get_drvdata(pdev); + spi_controller_get(spi->host); + + spi_unregister_controller(spi->host); + lantiq_ssc_writel(spi, 0, LTQ_SPI_IRNEN); lantiq_ssc_writel(spi, 0, LTQ_SPI_CLC); rx_fifo_flush(spi); @@ -1031,6 +1035,8 @@ static void lantiq_ssc_remove(struct pla destroy_workqueue(spi->wq); clk_disable_unprepare(spi->spi_clk); clk_put(spi->fpi_clk); + + spi_controller_put(spi->host); } static struct platform_driver lantiq_ssc_driver = {