From: sashiko-bot@kernel.org
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org
Subject: Re: [PATCH v1] Input: Use named initializers for arrays of i2c_device_data
Date: Fri, 15 May 2026 16:53:23 +0000 [thread overview]
Message-ID: <20260515165323.BCC6CC2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <20260515164848.497608-2-u.kleine-koenig@baylibre.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit title incorrectly references `i2c_device_data` instead of `i2c_device_id`.
--
commit f1077bbdac0316b24fea0fef5850a04e87106e2d
Author: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Input: Use named initializers for arrays of i2c_device_data
This commit updates the I2C device ID tables in various input drivers to
use named initializers. This improves readability and robustness, especially
in preparation for a planned change to struct i2c_device_id.
> Input: Use named initializers for arrays of i2c_device_data
This isn't a bug, but is there a typo in the subject line? The patch modifies
arrays of struct i2c_device_id, not i2c_device_data (which is correctly noted
in the commit body).
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260515164848.497608-2-u.kleine-koenig@baylibre.com?part=1
prev parent reply other threads:[~2026-05-15 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 16:48 [PATCH v1] Input: Use named initializers for arrays of i2c_device_data Uwe Kleine-König (The Capable Hub)
2026-05-15 16:53 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515165323.BCC6CC2BCB0@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.