Re: [PATCH net-next v5 8/8] selftests: drv-net: add netkit devmem tests

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The test function `check_nk_rx_hds` is missing the `@ksft_disruptive` decorator.
--

commit 6b7595d97efcd40188639cc504f84e6faae25b3e
Author: Bobby Eshleman <bobbyeshleman@meta.com>

selftests: drv-net: add netkit devmem tests

This commit adds nk_devmem.py with four tests for TCP devmem through a netkit
device. The tests duplicate the original devmem tests with adjusted parameters
for the netkit environment.

> diff --git a/tools/testing/selftests/drivers/net/hw/nk_devmem.py b/tools/testing/selftests/drivers/net/hw/nk_devmem.py
> new file mode 100755
> index 0000000000000..300ed2a70ab44
> --- /dev/null
> +++ b/tools/testing/selftests/drivers/net/hw/nk_devmem.py

[ ... ]

> +@ksft_disruptive
> +def check_nk_tx_chunks(cfg) -> None:
> +    """Run the devmem TX chunking test through netkit."""
> +    run_tx_chunks(cfg)
> +
> +
> +def check_nk_rx_hds(cfg) -> None:

Should check_nk_rx_hds() also be marked with the @ksft_disruptive decorator?

Since run_rx_hds() configures NIC hardware parameters (HDS, RSS, queue lease)
that bring the interface down and up, it appears this test will disrupt
network traffic.

Without the decorator, this function bypasses the framework's test filtering
and will run even if the user explicitly disables disruptive tests.

> +    """Run the HDS test through netkit."""
> +    run_rx_hds(cfg)
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514-tcp-dm-netkit-v5-0-408c59b91e66@meta.com?part=8