From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EA233D9DB3 for ; Fri, 15 May 2026 17:25:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778865941; cv=none; b=YcGMz/Lxc0h0THxy2ifu0iIMeF6tfQTc3vr7ciyV8T2u8EB95AXaSbboJxhMBnKqyxaz5eAvJMAcErchnXLg5wZKy1XejezgtFF/m59KwpyAO946b3tg6i3nbLcXM3AIXDtVK+2/QOJNTWOp7upHSLw3KYpLdykswayoSegmdW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778865941; c=relaxed/simple; bh=j+0yNXPywQF++Qj67M/KxDC1+69Wamni8Yw2VKlFDfg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SFekqOXo7e4F9xfQF0tNXHWW80Nph/cD45VzbhuwdMVWZZijYQWtXVXOVs2oDCFltOuOeVsXStv9I0uQf7ICWV42Ft3SioH4HeKtei4IfMgJaAtaTzn1amy+KRCoRhnCp2UNNaZ+SkYiGSJwQ/7gWnb70Mdn78PrhmYMKU6zUIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=MPOhzXLm; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="MPOhzXLm" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64FBPJTc001935; Fri, 15 May 2026 17:25:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=D8hZdXRFELLGxwxKs Os9GbFKmFLqkGzS1Um9Sszck2U=; b=MPOhzXLm3j3erzvFqxIbZQspR5LhvmjCI 3/Nd4B2GuatrWmjG9Y4ip3itoSh6kLUZ+OJHgYhk/QQCaJva7ax05hZ7S7+5GJlk kJa+b6KOtRAfApCZrNJ4FjX/AZtV8jpfXETuF8JcqEW3rskuXP+Trq6AfRYj6itq bG1LEuQJhTvd0Mq6OipQc7axT4OAPgusykkAgYwr3ZaJvBJ805DAtstojJpqRCgW 3AoEWCppyzd7H3I9znX0qrPWFO2kYLqEXQ2yrkTJ345/Ikov4ap88erHaoEpE6fL SmEm2vjruBISY7yIY7GtMyGdn/+RoagtzCiQAc9WSxURHwDZlPALg== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4e5m8y47k3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 May 2026 17:25:21 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 64FHO6lU028963; Fri, 15 May 2026 17:25:21 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4e5m3amgq1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 May 2026 17:25:21 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 64FHPJP615597946 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 15 May 2026 17:25:19 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2510A2004B; Fri, 15 May 2026 17:25:19 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C3D652004D; Fri, 15 May 2026 17:25:15 +0000 (GMT) Received: from li-7bb28a4c-2dab-11b2-a85c-887b5c60d769.ibm.com.com (unknown [9.39.30.78]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 15 May 2026 17:25:15 +0000 (GMT) From: Shrikanth Hegde To: mingo@kernel.org, peterz@infradead.org, vincent.guittot@linaro.org, linux-kernel@vger.kernel.org Cc: sshegde@linux.ibm.com, kprateek.nayak@amd.com, juri.lelli@redhat.com, vschneid@redhat.com, dietmar.eggemann@arm.com, tj@kernel.org, rostedt@goodmis.org, mgorman@suse.de, bsegall@google.com, arighi@nvidia.com, pauld@redhat.com Subject: [PATCH v4 4/4] sched: Unify SMT active check via sched_smt_active() Date: Fri, 15 May 2026 22:54:56 +0530 Message-ID: <20260515172456.542799-5-sshegde@linux.ibm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260515172456.542799-1-sshegde@linux.ibm.com> References: <20260515172456.542799-1-sshegde@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-GUID: XwxSsgNXW7JIhEcnw6YpHuBIKTAfTriN X-Authority-Analysis: v=2.4 cv=RemgzVtv c=1 sm=1 tr=0 ts=6a075702 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=20KFwNOVAAAA:8 a=VnNF1IyMAAAA:8 a=oDfC2TE6gg0lhyfcySYA:9 X-Proofpoint-ORIG-GUID: CvHZaEP7KhZXjfHQuDmx0Jesv1TR4CSa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDE3NSBTYWx0ZWRfX7w5cjHfx+Erc 8uCRRUYg08KKgJyfuev9Gpzb77HHIVIkDjVbxjAHSZRBliMel0r2/JqwlGL20GY7oTDKdM2rUL9 zWDgexdUvQH++heK6Y599a0MldKzlEwxlnkdfS7rbdukdiHFtwL8h7EapIv63Gc5tkvMsRTJkar Nd774n0OcGXiFUgDaaQ/qIRbc8yy0zmYkiNkNhOeiaTpK+vspO3iVdTSRCnb4zeLR6m0QZvIbmf 3T4UbeLmD+uFA0JPDHxsMyMm2+I7lOBfjwY9BQftG/IOsE224FFw54HIyYNSIYiKkNh2C7xKKEi 3nwsiHDJlpVz6Z9yFvMXMe5p/fWDxwwYaWwYMgBNZj1XSn+w/AGxoEa/8CnC948AKvxCObMQQnN D9RllmdvIaUIhFP4csqrnOqQLSljks01IO81M8iATZ/R/fyewDO6qC8f/OrTgdtSZjLobk59rpm 7O6DxlWvCcAWZocMaFg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_04,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 spamscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150175 There is a use of sched_smt_active() and explicit use of sched_smt_present. Remove the explicit usage for better code maintenance and readability. Note that this differs slightly for update_idle_core. It used to call static_branch_unlikely earlier and now it will call static_branch_likely. Reviewed-by: Valentin Schneider Signed-off-by: Shrikanth Hegde --- kernel/sched/core_sched.c | 2 +- kernel/sched/fair.c | 2 +- kernel/sched/sched.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/sched/core_sched.c b/kernel/sched/core_sched.c index 73b6b2426911..43e0bde3038e 100644 --- a/kernel/sched/core_sched.c +++ b/kernel/sched/core_sched.c @@ -136,7 +136,7 @@ int sched_core_share_pid(unsigned int cmd, pid_t pid, enum pid_type type, struct pid *grp; int err = 0; - if (!static_branch_likely(&sched_smt_present)) + if (!sched_smt_active()) return -ENODEV; BUILD_BUG_ON(PR_SCHED_CORE_SCOPE_THREAD != PIDTYPE_PID); diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index c0d66a10d01e..3e51b30ae7de 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2276,7 +2276,7 @@ numa_type numa_classify(unsigned int imbalance_pct, static inline bool test_idle_cores(int cpu); static inline int numa_idle_core(int idle_core, int cpu) { - if (!static_branch_likely(&sched_smt_present) || + if (!sched_smt_active() || idle_core >= 0 || !test_idle_cores(cpu)) return idle_core; diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index e476623a0c2a..ffe77b2b6296 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -1671,7 +1671,7 @@ extern void __update_idle_core(struct rq *rq); static inline void update_idle_core(struct rq *rq) { - if (static_branch_unlikely(&sched_smt_present)) + if (sched_smt_active()) __update_idle_core(rq); } -- 2.47.3