Re: [Buildroot] [PATCH v2 1/6] support/scripts/pkg-stats: search only Config.in{, .host} for URL

[Thomas Perale via buildroot <buildroot@buildroot.org>]

In reply of:
> The previous Config.* glob also caught linux/Config.ext.in and
> package/php/Config.ext, as well as some backup files created by
> editors (e.g. Config.in~ after editing a Config.in file in Emacs),
> leading to wrong results depending on directory listing order.
> 
> Also use "with" to automatically close the file when the block is
> left, even on error.
> 
> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>

Applied to 2025.02.x & 2026.02.x. Thanks

> ---
> This cannot solve the problem we have no structured URL information
> and don't look at which option the URL is listed under, but at least
> it's less wrong.
> 
> Changes v1 -> v2:
> * Try fixed names instead of globbing all directory entries
> 
>  support/scripts/pkg-stats | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/support/scripts/pkg-stats b/support/scripts/pkg-stats
> index 55aa63c861..efb85a7405 100755
> --- a/support/scripts/pkg-stats
> +++ b/support/scripts/pkg-stats
> @@ -148,17 +148,17 @@ class Package:
>          Fills in the .url field
>          """
>          self.status['url'] = ("warning", "no Config.in")
> -        for filename in os.listdir(self.pkgdir):
> -            if fnmatch.fnmatch(filename, 'Config.*'):
> -                fp = open(os.path.join(self.pkgdir, filename), "r")
> -                for config_line in fp:
> -                    if URL_RE.match(config_line):
> -                        self.url = config_line.strip()
> -                        self.status['url'] = ("ok", "found")
> -                        fp.close()
> -                        return
> -                self.status['url'] = ("error", "missing")
> -                fp.close()
> +        for filename in ('Config.in', 'Config.in.host'):
> +            try:
> +                with open(os.path.join(self.pkgdir, filename), "r") as fp:
> +                    for config_line in fp:
> +                        if URL_RE.match(config_line):
> +                            self.url = config_line.strip()
> +                            self.status['url'] = ("ok", "found")
> +                            return
> +                    self.status['url'] = ("error", "missing")
> +            except FileNotFoundError:
> +                continue
>  
>      @property
>      def patch_count(self):
> -- 
> 2.53.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot