From: sashiko-bot@kernel.org
To: "Oli R" <sigmatwojastara@gmail.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] treewide: replace /usr/bin/python3 shebangs with env python3
Date: Fri, 15 May 2026 18:15:47 +0000 [thread overview]
Message-ID: <20260515181547.99D82C2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <20260515180806.246914-1-sigmatwojastara@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Commit message states it replaces `#!/usr/bin/python3` shebangs and causes no functional changes, but actually changes `#!/usr/bin/python` to `#!/usr/bin/env python3` in `tools/perf/tests/shell/lib/perf_json_output_lint.py`.
--
commit 7d3e9689ede53be80434b3ba8cd07c27777d11ad
Author: Oli R <sigmatwojastara@gmail.com>
treewide: replace /usr/bin/python3 shebangs with env python3
This commit replaces hardcoded /usr/bin/python3 interpreter paths with
/usr/bin/env python3 to improve portability.
> treewide: replace /usr/bin/python3 shebangs with env python3
[ ... ]
> No functional changes intended.
Is this description accurate?
[ ... ]
> diff --git a/tools/perf/tests/shell/lib/perf_json_output_lint.py b/tools/perf/tests/shell/lib/perf_json_output_lint.py
> index dafbde56cc76f..dccafd507bb79 100644
> --- a/tools/perf/tests/shell/lib/perf_json_output_lint.py
> +++ b/tools/perf/tests/shell/lib/perf_json_output_lint.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/python
> +#!/usr/bin/env python3
Could this affect functionality on systems where python defaults to Python 2
or is managed differently?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260515180806.246914-1-sigmatwojastara@gmail.com?part=1
next prev parent reply other threads:[~2026-05-15 18:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 18:07 [PATCH] treewide: replace /usr/bin/python3 shebangs with env python3 Oli R
2026-05-15 18:15 ` sashiko-bot [this message]
2026-05-15 19:40 ` Ian Rogers
2026-05-17 17:21 ` Ian Rogers
2026-05-17 18:13 ` Dmitry Baryshkov
2026-05-18 23:55 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515181547.99D82C2BCB0@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sigmatwojastara@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.