[android-common:android17-6.18 2/2] arch/arm64/kvm/hyp_events.c:139:1: sparse: sparse: symbol 'hyp_ftrace_funcs_lock' was not declared. Should it be static?

[kernel test robot <lkp@intel.com>]

Hi Vincent,

FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.

tree:   https://android.googlesource.com/kernel/common android17-6.18
head:   6d689dd8b2631ce3829b6c20ff3b92cbc1c17599
commit: 7a99750a2422d095fb44d8f93887b336a449822b [2/2] ANDROID: KVM: arm64: PROTECTED_NVHE_FTRACE to PKVM_FTRACE
config: arm64-randconfig-r112-20260515 (https://download.01.org/0day-ci/archive/20260515/202605152132.Uk68x7Go-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 9.5.0
sparse: v0.6.5-rc1
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260515/202605152132.Uk68x7Go-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605152132.Uk68x7Go-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
   arch/arm64/kvm/hyp_events.c: note: in included file (through arch/arm64/include/asm/kvm_define_hypevents.h):
   arch/arm64/include/asm/kvm_hypevents.h:15:1: sparse: sparse: symbol 'hyp_event_func' was not declared. Should it be static?
   arch/arm64/include/asm/kvm_hypevents.h:28:1: sparse: sparse: symbol 'hyp_event_func_ret' was not declared. Should it be static?
   arch/arm64/include/asm/kvm_hypevents.h:40:1: sparse: sparse: symbol 'hyp_event_hyp_enter' was not declared. Should it be static?
   arch/arm64/include/asm/kvm_hypevents.h:49:1: sparse: sparse: symbol 'hyp_event_hyp_exit' was not declared. Should it be static?
   arch/arm64/include/asm/kvm_hypevents.h:58:1: sparse: sparse: symbol 'hyp_event_host_hcall' was not declared. Should it be static?
   arch/arm64/include/asm/kvm_hypevents.h:72:1: sparse: sparse: symbol 'hyp_event_host_smc' was not declared. Should it be static?
   arch/arm64/include/asm/kvm_hypevents.h:87:1: sparse: sparse: symbol 'hyp_event_host_mem_abort' was not declared. Should it be static?
   arch/arm64/include/asm/kvm_hypevents.h:101:1: sparse: sparse: symbol 'hyp_event___hyp_printk' was not declared. Should it be static?
   arch/arm64/include/asm/kvm_hypevents.h:121:1: sparse: sparse: symbol 'hyp_event_psci_mem_protect' was not declared. Should it be static?
   arch/arm64/include/asm/kvm_hypevents.h:134:1: sparse: sparse: symbol 'hyp_event_vcpu_illegal_trap' was not declared. Should it be static?
   arch/arm64/kvm/hyp_events.c:51:15: sparse: sparse: incompatible types in comparison expression (different address spaces):
   arch/arm64/kvm/hyp_events.c:51:15: sparse:    struct hyp_table [noderef] __rcu *
   arch/arm64/kvm/hyp_events.c:51:15: sparse:    struct hyp_table *
   arch/arm64/kvm/hyp_events.c:51:15: sparse: sparse: incompatible types in comparison expression (different address spaces):
   arch/arm64/kvm/hyp_events.c:51:15: sparse:    struct hyp_table [noderef] __rcu *
   arch/arm64/kvm/hyp_events.c:51:15: sparse:    struct hyp_table *
   arch/arm64/kvm/hyp_events.c:66:17: sparse: sparse: incompatible types in comparison expression (different address spaces):
   arch/arm64/kvm/hyp_events.c:66:17: sparse:    struct hyp_table [noderef] __rcu *
   arch/arm64/kvm/hyp_events.c:66:17: sparse:    struct hyp_table *
>> arch/arm64/kvm/hyp_events.c:139:1: sparse: sparse: symbol 'hyp_ftrace_funcs_lock' was not declared. Should it be static?
>> arch/arm64/kvm/hyp_events.c:417:23: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [usertype] @@     got restricted __le32 [usertype] @@
   arch/arm64/kvm/hyp_events.c:417:23: sparse:     expected unsigned int [usertype]
   arch/arm64/kvm/hyp_events.c:417:23: sparse:     got restricted __le32 [usertype]
   arch/arm64/kvm/hyp_events.c:428:15: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [usertype] @@     got restricted __le32 [usertype] @@
   arch/arm64/kvm/hyp_events.c:428:15: sparse:     expected unsigned int [usertype]
   arch/arm64/kvm/hyp_events.c:428:15: sparse:     got restricted __le32 [usertype]
   arch/arm64/kvm/hyp_events.c:716:17: sparse: sparse: incompatible types in comparison expression (different address spaces):
   arch/arm64/kvm/hyp_events.c:716:17: sparse:    struct hyp_table [noderef] __rcu *
   arch/arm64/kvm/hyp_events.c:716:17: sparse:    struct hyp_table *
--
>> arch/arm64/kvm/hyp/nvhe/ftrace.c:147:15: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [usertype] @@     got restricted __le32 [usertype] @@
   arch/arm64/kvm/hyp/nvhe/ftrace.c:147:15: sparse:     expected unsigned int [usertype]
   arch/arm64/kvm/hyp/nvhe/ftrace.c:147:15: sparse:     got restricted __le32 [usertype]
   arch/arm64/kvm/hyp/nvhe/ftrace.c:160:15: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [usertype] @@     got restricted __le32 [usertype] @@
   arch/arm64/kvm/hyp/nvhe/ftrace.c:160:15: sparse:     expected unsigned int [usertype]
   arch/arm64/kvm/hyp/nvhe/ftrace.c:160:15: sparse:     got restricted __le32 [usertype]
   arch/arm64/kvm/hyp/nvhe/ftrace.c:180:15: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [usertype] @@     got restricted __le32 [usertype] @@
   arch/arm64/kvm/hyp/nvhe/ftrace.c:180:15: sparse:     expected unsigned int [usertype]
   arch/arm64/kvm/hyp/nvhe/ftrace.c:180:15: sparse:     got restricted __le32 [usertype]
   arch/arm64/kvm/hyp/nvhe/ftrace.c:250:23: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [usertype] @@     got restricted __le32 [usertype] @@
   arch/arm64/kvm/hyp/nvhe/ftrace.c:250:23: sparse:     expected unsigned int [usertype]
   arch/arm64/kvm/hyp/nvhe/ftrace.c:250:23: sparse:     got restricted __le32 [usertype]

vim +/hyp_ftrace_funcs_lock +139 arch/arm64/kvm/hyp_events.c

76c84a105cca9c Vincent Donnefort 2024-10-01  138  
76c84a105cca9c Vincent Donnefort 2024-10-01 @139  DEFINE_MUTEX(hyp_ftrace_funcs_lock);
76c84a105cca9c Vincent Donnefort 2024-10-01  140  

:::::: The code at line 139 was first introduced by commit
:::::: 76c84a105cca9cfc5a218539bb401a58ab12d3e9 ANDROID: KVM: arm64: Add set_ftrace_filter for pKVM hyp

:::::: TO: Vincent Donnefort <vdonnefort@google.com>
:::::: CC: Fuad Tabba <tabba@google.com>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki