From: sashiko-bot@kernel.org
To: "Chris Morgan" <macroalpha82@gmail.com>
Cc: krzk+dt@kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH V2 3/6] dt-bindings: display: panel: document Anbernic TD4310 panel
Date: Fri, 15 May 2026 22:55:23 +0000 [thread overview]
Message-ID: <20260515225524.19DC2C2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <20260515221947.299229-4-macroalpha82@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The YAML filename does not match the compatible string.
--
commit 5f66eb8e2fe14ce244cbb7ee82f13643cfae18e7
Author: Chris Morgan <macromorgan@hotmail.com>
dt-bindings: display: panel: document Anbernic TD4310 panel
This commit introduces a new device tree binding for the TD4310-based panel
used in the Anbernic RG Vita-Pro device.
> diff --git a/Documentation/devicetree/bindings/display/panel/anbernic,td4310.yaml b/Documentation/devicetree/bindings/display/panel/anbernic,td4310.yaml
> new file mode 100644
> index 0000000000000..5068dd6b2d524
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/anbernic,td4310.yaml
[ ... ]
> +properties:
> + compatible:
> + items:
> + - const: anbernic,panel-vita-pro
This isn't a bug, but the YAML filename is anbernic,td4310.yaml while the
only defined compatible string is anbernic,panel-vita-pro.
According to device tree schema guidelines, the YAML filename should generally
match the compatible string.
Should the filename be renamed to anbernic,panel-vita-pro.yaml, or should
anbernic,td4310 be added as a compatible string here?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260515221947.299229-1-macroalpha82@gmail.com?part=3
next prev parent reply other threads:[~2026-05-15 22:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 22:19 [PATCH V2 0/6] Add Anbernic RG Vita-Pro Chris Morgan
2026-05-15 22:19 ` Chris Morgan
2026-05-15 22:19 ` [PATCH V2 1/6] dt-bindings: power: supply: sgm41542: document sgm41542 Chris Morgan
2026-05-15 22:19 ` Chris Morgan
2026-05-15 22:26 ` sashiko-bot
2026-05-15 22:19 ` [PATCH V2 2/6] power: supply: sgm41542: Add SG Micro sgm41542 charger Chris Morgan
2026-05-15 22:19 ` Chris Morgan
2026-05-15 22:48 ` sashiko-bot
2026-05-15 22:19 ` [PATCH V2 3/6] dt-bindings: display: panel: document Anbernic TD4310 panel Chris Morgan
2026-05-15 22:19 ` Chris Morgan
2026-05-15 22:55 ` sashiko-bot [this message]
2026-05-15 22:19 ` [PATCH V2 4/6] drm/panel: anbernic-td4310: Add RG Vita Pro panel Chris Morgan
2026-05-15 22:19 ` Chris Morgan
2026-05-15 23:10 ` sashiko-bot
2026-05-15 22:19 ` [PATCH V2 5/6] dt-bindings: arm: rockchip: Add Anbernic RG Vita-Pro Chris Morgan
2026-05-15 22:19 ` Chris Morgan
2026-05-15 22:19 ` [PATCH V2 6/6] arm64: dts: " Chris Morgan
2026-05-15 22:19 ` Chris Morgan
2026-05-15 23:31 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515225524.19DC2C2BCB0@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=macroalpha82@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.