All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [frank-w-bpi-r2-4.14:7.1-rc 81/154] drivers/net/ethernet/mediatek/mtk_eth_soc.c:5722 mtk_sgmii_init() warn: inconsistent indenting
Date: Sat, 16 May 2026 00:34:59 +0800	[thread overview]
Message-ID: <202605160011.eVtx3DR1-lkp@intel.com> (raw)

Hi Frank,

First bad commit (maybe != root cause):

tree:   https://github.com/frank-w/BPI-R2-4.14 7.1-rc
head:   767536110bfe28c94ae2e150c083d29f827655cf
commit: 922b961be45c1aee8960f9e8f2a690191353bc5f [81/154] net: ethernet: mtk_eth_soc: rss-changes for mt7987
config: arc-randconfig-r072-20260515 (https://download.01.org/0day-ci/archive/20260516/202605160011.eVtx3DR1-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 10.5.0
smatch: v0.5.0-9185-gbcc58b9c

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605160011.eVtx3DR1-lkp@intel.com/

New smatch warnings:
drivers/net/ethernet/mediatek/mtk_eth_soc.c:5722 mtk_sgmii_init() warn: inconsistent indenting

Old smatch warnings:
drivers/net/ethernet/mediatek/mtk_eth_soc.c:6024 mtk_probe() error: buffer overflow 'eth->irq_pdma' 4 <= 4

vim +5722 drivers/net/ethernet/mediatek/mtk_eth_soc.c

d776a57e4a284b3 Felix Fietkau   2022-04-05  5705  
2a3ec7ae313310c Daniel Golle    2023-03-19  5706  static int mtk_sgmii_init(struct mtk_eth *eth)
2a3ec7ae313310c Daniel Golle    2023-03-19  5707  {
2a3ec7ae313310c Daniel Golle    2023-03-19  5708  	struct device_node *np;
2a3ec7ae313310c Daniel Golle    2023-03-19  5709  	struct regmap *regmap;
188fbd9a282fbed Bo-Cun Chen     2025-05-06  5710  	u32 flags = 0;
2a3ec7ae313310c Daniel Golle    2023-03-19  5711  	int i;
2a3ec7ae313310c Daniel Golle    2023-03-19  5712  
2a3ec7ae313310c Daniel Golle    2023-03-19  5713  	for (i = 0; i < MTK_MAX_DEVS; i++) {
2a3ec7ae313310c Daniel Golle    2023-03-19  5714  		np = of_parse_phandle(eth->dev->of_node, "mediatek,sgmiisys", i);
2a3ec7ae313310c Daniel Golle    2023-03-19  5715  		if (!np)
2a3ec7ae313310c Daniel Golle    2023-03-19  5716  			break;
2a3ec7ae313310c Daniel Golle    2023-03-19  5717  
2a3ec7ae313310c Daniel Golle    2023-03-19  5718  		regmap = syscon_node_to_regmap(np);
bde1ae2d52ab359 Vladimir Oltean 2026-01-19  5719  		if (IS_ERR(regmap)) {
2a3ec7ae313310c Daniel Golle    2023-03-19  5720  			of_node_put(np);
188fbd9a282fbed Bo-Cun Chen     2025-05-06  5721  
188fbd9a282fbed Bo-Cun Chen     2025-05-06 @5722  		if (of_property_read_bool(np->parent, "mediatek,phya_trx_ck"))
188fbd9a282fbed Bo-Cun Chen     2025-05-06  5723  			flags |= MTK_SGMII_FLAG_PHYA_TRX_CK;
188fbd9a282fbed Bo-Cun Chen     2025-05-06  5724  
188fbd9a282fbed Bo-Cun Chen     2025-05-06  5725  		of_node_put(np);
188fbd9a282fbed Bo-Cun Chen     2025-05-06  5726  
188fbd9a282fbed Bo-Cun Chen     2025-05-06  5727  		if (IS_ERR(regmap))
2a3ec7ae313310c Daniel Golle    2023-03-19  5728  			return PTR_ERR(regmap);
bde1ae2d52ab359 Vladimir Oltean 2026-01-19  5729  		}
2a3ec7ae313310c Daniel Golle    2023-03-19  5730  
bde1ae2d52ab359 Vladimir Oltean 2026-01-19  5731  		eth->sgmii_pcs[i] = mtk_pcs_lynxi_create(eth->dev,
bde1ae2d52ab359 Vladimir Oltean 2026-01-19  5732  							 of_fwnode_handle(np),
bde1ae2d52ab359 Vladimir Oltean 2026-01-19  5733  							 regmap,
bde1ae2d52ab359 Vladimir Oltean 2026-01-19  5734  							 eth->soc->ana_rgc3);
bde1ae2d52ab359 Vladimir Oltean 2026-01-19  5735  		of_node_put(np);
2a3ec7ae313310c Daniel Golle    2023-03-19  5736  	}
2a3ec7ae313310c Daniel Golle    2023-03-19  5737  
2a3ec7ae313310c Daniel Golle    2023-03-19  5738  	return 0;
2a3ec7ae313310c Daniel Golle    2023-03-19  5739  }
2a3ec7ae313310c Daniel Golle    2023-03-19  5740  

:::::: The code at line 5722 was first introduced by commit
:::::: 188fbd9a282fbed6a7a43430ab5d611dacfee1c5 net: pcs: mtk-lynxi: add phya tx rx clock path

:::::: TO: Bo-Cun Chen <bc-bocun.chen@mediatek.com>
:::::: CC: Frank Wunderlich <frank-w@public-files.de>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-05-15 16:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202605160011.eVtx3DR1-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=frank-w@public-files.de \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.