Re: [PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Mismatch between node unit-address and 'reg' property for the uboot partition.
--

commit ac1df28fb4536a816c17f35ce989f0804943afb5
Author: Chukun Pan <amadeus@jmu.edu.cn>

riscv: dts: spacemit: enable QSPI for OrangePi RV2

This commit enables the QSPI controller and the XM25QU128C SPI NOR flash
on the OrangePi RV2 board. It also adds a flash partition layout derived
from the vendor U-Boot.

> diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
> --- a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
[ ... ]
> +			opensbi@70000 {
> +				reg = <0x70000 0x030000>;
> +			};
> +
> +			uboot@a00000 {
> +				reg = <0xa0000 0x760000>;

Is there a mismatch between the unit-address and the reg property here?

The node name uses a00000 (implying an address of 0xa00000), but the reg
property specifies a start address of 0xa0000. 

This difference will usually trigger a unit_address_vs_reg warning when
compiling the device tree with dtc. Should the node name or the reg address
be updated so they match exactly?

> +			};
> +		};
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260516080030.1736836-1-amadeus@jmu.edu.cn?part=1