Re: [PATCH v6 2/3] arm64: dts: qcom: Add Xiaomi 12 Lite 5G (taoyao) DTS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The ramoops memory region is entirely consumed by `pmsg-size`, silently breaking kernel crash dumps.
- [Low] Device Tree unit address mismatch in the `rmtfs_mem` reserved memory node.
--

commit cc4a7cf1d691d4d94cb9b845a5a49075f69a93ff
Author: Stanislav Zaikin <zstaseg@gmail.com>

arm64: dts: qcom: Add Xiaomi 12 Lite 5G (taoyao) DTS

This commit adds device tree support for the Xiaomi 12 Lite 5G handset,
enabling features such as display, touchscreen, UFS, power/volume buttons,
and remoteprocs.

> diff --git a/arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts b/arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts
> new file mode 100644
> index 0000000000000..eb83da4b836e1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm7325-xiaomi-taoyao.dts

[ ... ]

> +		ramoops@a9000000 {
> +			compatible = "ramoops";
> +			reg = <0x0 0xa9000000 0x0 0x200000>;
> +			pmsg-size = <0x200000>;

Does this configuration leave any room for kernel crash dumps?

The node defines a memory region of exactly 2MB, but pmsg-size consumes the
entire 0x200000 bytes. Because pmsg-size consumes all available space, zero
space remains for record-size (which defaults to 0). Will the pstore/ramoops
driver be able to store kernel dmesg during panics or oops with this setup?

> +			mem-type = <2>;
> +		};

[ ... ]

> +		rmtfs_mem: rmtfs@ef500000 {
> +			compatible = "qcom,rmtfs-mem";
> +			reg = <0x0 0xe7d00000 0x0 0x280000>;

Is this unit address intentionally mismatched with the reg property?

The node is named rmtfs@ef500000, but its reg property specifies a base
address of 0xe7d00000. Can this structural syntax violation trigger a
simple_bus_reg dtc compiler warning?

> +			no-map;
> +
> +			qcom,client-id = <1>;
> +			qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>,
> +				    <QCOM_SCM_VMID_NAV>;
> +		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260516090853.2873223-1-zstaseg@gmail.com?part=2