From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Crofts via B4 Relay <devnull+joshua.crofts1.gmail.com@kernel.org>
Cc: joshua.crofts1@gmail.com, "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Alexander Koch" <mail@alexanderkoch.net>,
"Michael Hornung" <mhornung.linux@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 09/10] iio: light: opt3001: switch driver to managed resources
Date: Sat, 16 May 2026 13:10:17 +0100 [thread overview]
Message-ID: <20260516131017.3de30733@jic23-huawei> (raw)
In-Reply-To: <20260512152600.764ff7c7@jic23-huawei>
On Tue, 12 May 2026 15:26:00 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> On Tue, 12 May 2026 12:57:29 +0200
> Joshua Crofts via B4 Relay <devnull+joshua.crofts1.gmail.com@kernel.org> wrote:
>
> > From: Joshua Crofts <joshua.crofts1@gmail.com>
> >
> > Move the driver to use devm_* functions to automate resource
> > management and simplify error handling. This also allows removal
> > of the opt3001_remove() function.
> >
> > Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> Some trivial stuff inline. I'll probably wait for sashiko to catch up with
> it's backlog and get to this one. If nothing comes up there or in other reviews
> I'm fine tweaking the stuff below whilst applying the series.
>
Sashiko did come back with a lifetime issue.
I think it's a false positive as there aren't any workqueues or similar
that might still be active. IRQs will long have been cleaned up before
the mutex_destroy() occurs.
Anyhow, do take a look
https://sashiko.dev/#/patchset/20260512-opt3001-cleanup-v2-0-8018cf3a8a0a%40gmail.com
and make sure I'm not missing anything!
Jonathan
next prev parent reply other threads:[~2026-05-16 12:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 10:57 [PATCH v2 00/10] iio: light: opt3001: driver cleanup Joshua Crofts
2026-05-12 10:57 ` Joshua Crofts via B4 Relay
2026-05-12 10:57 ` [PATCH v2 01/10] iio: light: opt3001: move device registration to end of probe() Joshua Crofts
2026-05-12 10:57 ` Joshua Crofts via B4 Relay
2026-05-16 11:56 ` Jonathan Cameron
2026-05-12 10:57 ` [PATCH v2 02/10] iio: light: opt3001: make headers conform to iwyu Joshua Crofts
2026-05-12 10:57 ` Joshua Crofts via B4 Relay
2026-05-16 11:58 ` Jonathan Cameron
2026-05-12 10:57 ` [PATCH v2 03/10] iio: light: opt3001: use macros from bits.h header Joshua Crofts
2026-05-12 10:57 ` Joshua Crofts via B4 Relay
2026-05-16 12:00 ` Jonathan Cameron
2026-05-12 10:57 ` [PATCH v2 04/10] iio: light: opt3001: use local struct device and i2c_client variables Joshua Crofts
2026-05-12 10:57 ` Joshua Crofts via B4 Relay
2026-05-12 11:09 ` Andy Shevchenko
2026-05-12 11:13 ` Joshua Crofts
2026-05-12 11:27 ` Andy Shevchenko
2026-05-16 12:02 ` Jonathan Cameron
2026-05-12 10:57 ` [PATCH v2 05/10] iio: light: opt3001: ensure correct parenthesis alignment Joshua Crofts
2026-05-12 10:57 ` Joshua Crofts via B4 Relay
2026-05-12 10:57 ` [PATCH v2 06/10] iio: light: opt3001: localize for loop iterator Joshua Crofts
2026-05-12 10:57 ` Joshua Crofts via B4 Relay
2026-05-12 15:40 ` Andy Shevchenko
2026-05-12 10:57 ` [PATCH v2 07/10] iio: light: opt3001: prefer dev_err_probe() Joshua Crofts
2026-05-12 10:57 ` Joshua Crofts via B4 Relay
2026-05-12 15:43 ` Andy Shevchenko
2026-05-12 10:57 ` [PATCH v2 08/10] iio: light: opt3001: move driver to guard(mutex)() use Joshua Crofts
2026-05-12 10:57 ` Joshua Crofts via B4 Relay
2026-05-16 12:05 ` Jonathan Cameron
2026-05-12 10:57 ` [PATCH v2 09/10] iio: light: opt3001: switch driver to managed resources Joshua Crofts
2026-05-12 10:57 ` Joshua Crofts via B4 Relay
2026-05-12 14:26 ` Jonathan Cameron
2026-05-12 14:32 ` Joshua Crofts
2026-05-16 12:10 ` Jonathan Cameron [this message]
2026-05-12 10:57 ` [PATCH v2 10/10] iio: light: opt3001: add comment to mutex Joshua Crofts
2026-05-12 10:57 ` Joshua Crofts via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260516131017.3de30733@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=devnull+joshua.crofts1.gmail.com@kernel.org \
--cc=dlechner@baylibre.com \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@alexanderkoch.net \
--cc=mhornung.linux@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.