From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH v3 16/28] mm/damon/sysfs-schemes: implement probe dir
Date: Sat, 16 May 2026 11:36:57 -0700 [thread overview]
Message-ID: <20260516183712.81393-17-sj@kernel.org> (raw)
In-Reply-To: <20260516183712.81393-1-sj@kernel.org>
Implement sysfs directory for showing per-probe hits count of each
region.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
mm/damon/sysfs-schemes.c | 101 ++++++++++++++++++++++++++++++++++++---
1 file changed, 95 insertions(+), 6 deletions(-)
diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
index 8998df5bdc5c8..c8123c62bbd48 100644
--- a/mm/damon/sysfs-schemes.c
+++ b/mm/damon/sysfs-schemes.c
@@ -10,12 +10,40 @@
#include "sysfs-common.h"
+/*
+ * probe directory
+ */
+
+struct damos_sysfs_probe {
+ struct kobject kobj;
+};
+
+static struct damos_sysfs_probe *damos_sysfs_probe_alloc(void)
+{
+ return kzalloc_obj(struct damos_sysfs_probe);
+}
+
+static void damos_sysfs_probe_release(struct kobject *kobj)
+{
+ struct damos_sysfs_probe *probe = container_of(kobj,
+ struct damos_sysfs_probe, kobj);
+
+ kfree(probe);
+}
+
+static const struct kobj_type damos_sysfs_probe_ktype = {
+ .release = damos_sysfs_probe_release,
+ .sysfs_ops = &kobj_sysfs_ops,
+};
+
/*
* probes directory
*/
struct damos_sysfs_probes {
struct kobject kobj;
+ struct damos_sysfs_probe **probes_arr;
+ int nr;
};
static struct damos_sysfs_probes *damos_sysfs_probes_alloc(void)
@@ -23,6 +51,60 @@ static struct damos_sysfs_probes *damos_sysfs_probes_alloc(void)
return kzalloc_obj(struct damos_sysfs_probes);
}
+static void damos_sysfs_probes_rm_dirs(struct damos_sysfs_probes *probes)
+{
+ struct damos_sysfs_probe **probes_arr = probes->probes_arr;
+ int i;
+
+ for (i = 0; i < probes->nr; i++)
+ kobject_put(&probes_arr[i]->kobj);
+ probes->nr = 0;
+ kfree(probes_arr);
+ probes->probes_arr = NULL;
+}
+
+static int damos_sysfs_probes_add_dirs(struct damos_sysfs_probes *probes,
+ struct damon_ctx *ctx)
+{
+ struct damon_probe *probe;
+ struct damos_sysfs_probe **probes_arr;
+ int i = 0;
+
+ damon_for_each_probe(probe, ctx)
+ i++;
+
+ if (!i)
+ return 0;
+
+ probes_arr = kmalloc_objs(*probes_arr, i);
+ if (!probes_arr)
+ return -ENOMEM;
+ probes->probes_arr = probes_arr;
+
+ i = 0;
+ damon_for_each_probe(probe, ctx) {
+ struct damos_sysfs_probe *sys_probe;
+ int err;
+
+ sys_probe = damos_sysfs_probe_alloc();
+ if (!sys_probe) {
+ damos_sysfs_probes_rm_dirs(probes);
+ return -ENOMEM;
+ }
+ err = kobject_init_and_add(&sys_probe->kobj,
+ &damos_sysfs_probe_ktype, &probes->kobj, "%d",
+ i);
+ if (err) {
+ kobject_put(&sys_probe->kobj);
+ damos_sysfs_probes_rm_dirs(probes);
+ return err;
+ }
+ probes_arr[i++] = sys_probe;
+ probes->nr++;
+ }
+ return 0;
+}
+
static void damos_sysfs_probes_release(struct kobject *kobj)
{
struct damos_sysfs_probes *probes = container_of(kobj,
@@ -67,7 +149,8 @@ static struct damon_sysfs_scheme_region *damon_sysfs_scheme_region_alloc(
}
static int damos_sysfs_region_add_dirs(
- struct damon_sysfs_scheme_region *region)
+ struct damon_sysfs_scheme_region *region,
+ struct damon_ctx *ctx)
{
struct damos_sysfs_probes *probes = damos_sysfs_probes_alloc();
int err;
@@ -76,18 +159,24 @@ static int damos_sysfs_region_add_dirs(
return -ENOMEM;
err = kobject_init_and_add(&probes->kobj, &damos_sysfs_probes_ktype,
®ion->kobj, "probes");
- if (err) {
- kobject_put(&probes->kobj);
- return err;
- }
+ if (err)
+ goto fail;
+ err = damos_sysfs_probes_add_dirs(probes, ctx);
+ if (err)
+ goto fail;
region->probes = probes;
return 0;
+
+fail:
+ kobject_put(&probes->kobj);
+ return err;
}
static void damos_sysfs_region_rm_dirs(
struct damon_sysfs_scheme_region *region)
{
+ damos_sysfs_probes_rm_dirs(region->probes);
kobject_put(®ion->probes->kobj);
}
@@ -2986,7 +3075,7 @@ void damos_sysfs_populate_region_dir(struct damon_sysfs_schemes *sysfs_schemes,
&sysfs_regions->kobj, "%d",
sysfs_regions->nr_regions++))
goto out;
- if (damos_sysfs_region_add_dirs(region))
+ if (damos_sysfs_region_add_dirs(region, ctx))
goto out;
list_add_tail(®ion->list, &sysfs_regions->regions_list);
--
2.47.3
next prev parent reply other threads:[~2026-05-16 18:37 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-16 18:36 [RFC PATCH v3 00/28] mm/damon: introduce data attributes monitoring SeongJae Park
2026-05-16 18:36 ` [RFC PATCH v3 01/28] mm/damon/core: introduce struct damon_probe SeongJae Park
2026-05-16 18:36 ` [RFC PATCH v3 02/28] mm/damon/core: embed damon_probe objects in damon_ctx SeongJae Park
2026-05-16 18:36 ` [RFC PATCH v3 03/28] mm/damon/core: introduce damon_filter SeongJae Park
2026-05-16 18:36 ` [RFC PATCH v3 04/28] mm/damon/core: commit probes SeongJae Park
2026-05-16 18:36 ` [RFC PATCH v3 05/28] mm/damon/core: introduce damon_region->probe_hits SeongJae Park
2026-05-16 18:54 ` sashiko-bot
2026-05-16 21:26 ` SeongJae Park
2026-05-16 18:36 ` [RFC PATCH v3 06/28] mm/damon/core: introduce damon_ops->apply_probes SeongJae Park
2026-05-16 18:36 ` [RFC PATCH v3 07/28] mm/damon/core: do data attributes monitoring SeongJae Park
2026-05-16 19:00 ` sashiko-bot
2026-05-16 21:33 ` SeongJae Park
2026-05-16 18:36 ` [RFC PATCH v3 08/28] mm/damon/paddr: support " SeongJae Park
2026-05-16 19:05 ` sashiko-bot
2026-05-16 21:46 ` SeongJae Park
2026-05-16 18:36 ` [RFC PATCH v3 09/28] mm/damon/sysfs: implement probes dir SeongJae Park
2026-05-16 18:36 ` [RFC PATCH v3 10/28] mm/damon/sysfs: implement probe dir SeongJae Park
2026-05-16 18:36 ` [RFC PATCH v3 11/28] mm/damon/sysfs: implement filters directory SeongJae Park
2026-05-16 18:36 ` [RFC PATCH v3 12/28] mm/damon/sysfs: implement filter dir SeongJae Park
2026-05-16 18:36 ` [RFC PATCH v3 13/28] mm/damon/sysfs: implement filter dir files SeongJae Park
2026-05-16 18:36 ` [RFC PATCH v3 14/28] mm/damon/sysfs: setup probes on DAMON core API parameters SeongJae Park
2026-05-16 18:36 ` [RFC PATCH v3 15/28] mm/damon/sysfs-schemes: implement tried_regions/<r>/probes/ SeongJae Park
2026-05-16 18:36 ` SeongJae Park [this message]
2026-05-16 18:36 ` [RFC PATCH v3 17/28] mm/damon/sysfs-schemes: implement probe/hits file SeongJae Park
2026-05-16 18:36 ` [RFC PATCH v3 18/28] mm/damon: trace probe_hits SeongJae Park
2026-05-16 18:37 ` [RFC PATCH v3 19/28] selftests/damon/sysfs.sh: test probes dir SeongJae Park
2026-05-16 18:37 ` [RFC PATCH v3 20/28] Docs/mm/damon/design: document data attributes monitoring SeongJae Park
2026-05-16 18:37 ` [RFC PATCH v3 21/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2026-05-16 18:37 ` [RFC PATCH v3 22/28] mm/damon/core: introduce DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-16 18:37 ` [RFC PATCH v3 23/28] mm/damon/paddr: support DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-16 18:37 ` [RFC PATCH v3 24/28] mm/damon/sysfs: add filters/<F>/path file SeongJae Park
2026-05-16 19:29 ` sashiko-bot
2026-05-16 21:51 ` SeongJae Park
2026-05-16 18:37 ` [RFC PATCH v3 25/28] mm/damon/sysfs-schemes: move memcg_path_to_id() to sysfs-common SeongJae Park
2026-05-16 19:16 ` sashiko-bot
2026-05-16 21:54 ` SeongJae Park
2026-05-16 18:37 ` [RFC PATCH v3 26/28] mm/damon/sysfs: setup damon_filter->memcg_id from path SeongJae Park
2026-05-16 18:37 ` [RFC PATCH v3 27/28] Docs/mm/damon/design: update for memcg damon filter SeongJae Park
2026-05-16 18:37 ` [RFC PATCH v3 28/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2026-05-16 19:09 ` sashiko-bot
2026-05-16 21:57 ` SeongJae Park
2026-05-16 18:50 ` [RFC PATCH v3 00/28] mm/damon: introduce data attributes monitoring SeongJae Park
2026-05-16 22:03 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260516183712.81393-17-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.