Re: [PATCH v2 1/2] soc: bcm2835: raspberrypi-firmware: Add voltage domain IDs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The voltage domain IDs for SDRAM_I and SDRAM_P are swapped, violating the Raspberry Pi firmware mailbox property interface.
--

commit 55efe0976ecb0653da890b61d597ee771424aed8
Author: Shubham Chakraborty <chakrabortyshubham66@gmail.com>

soc: bcm2835: raspberrypi-firmware: Add voltage domain IDs

This commit adds firmware voltage domain identifiers for the Raspberry Pi
mailbox property interface. Firmware clients use these IDs to query voltage
rails via the RPI_FIRMWARE_GET_VOLTAGE property.

> diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h
> index e1f87fbfe5542..fd2e051ce05b7 100644
> --- a/include/soc/bcm2835/raspberrypi-firmware.h
> +++ b/include/soc/bcm2835/raspberrypi-firmware.h

[ ... ]

> +enum rpi_firmware_volt_id {
> +	RPI_FIRMWARE_VOLT_ID_RESERVED = 0,
> +	RPI_FIRMWARE_VOLT_ID_CORE = 1,
> +	RPI_FIRMWARE_VOLT_ID_SDRAM_C = 2,
> +	RPI_FIRMWARE_VOLT_ID_SDRAM_I = 3,
> +	RPI_FIRMWARE_VOLT_ID_SDRAM_P = 4,

Are the IDs for SDRAM_I and SDRAM_P swapped here?

According to the official Raspberry Pi mailbox property interface, the
voltage domain IDs are defined as SDRAM_P (PHY) = 3 and SDRAM_I (I/O) = 4.

If these values are inverted, could it cause firmware clients that query or
modify these domains to access the wrong voltage rails? This might lead
to incorrect voltage reporting or hardware instability if used by scaling
drivers.

> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260516191555.17978-1-chakrabortyshubham66@gmail.com?part=1