From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AC47367F54; Sat, 16 May 2026 19:52:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778961145; cv=none; b=jFx5c13yk2I8iEeiQMAlxgeVXuGgQ+JvA42XlVnW3y3NX3f/q/Hdv2u7T5s1s7IBfJNcjT7D6e8Ig7d6cDQBBeoRE8bF051lSF9G7GR1HYoKLbHO1K2nZhZpEA3iqZi2LJrK0SEe2IwRbj2BxmL3Wo/cphFzhjSmTFoOABQ2SGs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778961145; c=relaxed/simple; bh=fAsWNGwQAqu+EJ+8N3R741IrNe5Q1D1pfyWbyfS013c=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=H9ceFquAKjgDXQugJLs59iYSovSUhhpPV65ZSCGEb24b/LEr/sPHtUgg2tfV+qYwx0BM6GRTpPNPYlKefa53EAw3m9gYW8BO63IRayQaEWI45aUOykjODnLkhllai2AuhphemDWPzS8TP1EgFeTVa0+C6TnmwIcNVG01MKVHWvY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jkD+Pp0m; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jkD+Pp0m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E2CBC19425; Sat, 16 May 2026 19:52:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778961144; bh=fAsWNGwQAqu+EJ+8N3R741IrNe5Q1D1pfyWbyfS013c=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=jkD+Pp0mnYYfYMurlZ0SylntRAn6adUMDneQodqK2Yynhiiqww3xyg206Mlm3OCmO Nx8Tca0M4muyaUFAKOzJ26mQsfG9ixOI5NQBxWGQsIy9uadf66v3Sf6vOgZwERq6ss iAnA1b4nyw1MOXw+DFw1j3BE76yIj1faGc+uFYDae1WRFeHvOs6ej4OHVkZVM/l2XJ U2IYcgAal+X+CjB2B1o1YOva8k0BdmDpyr+7dCWakTlrznZhLhb7zpwOdSbmxdQzNY P/jXi1/GzsDXfqYdR/1hhR5ckBnWXZt54xMDKn10YWfXgqdrrrqo0xoe1zQTtWUdgs aI6WaxiO6UAAQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 17/22] drm: bridge: dw_hdmi: Drop call to drm_bridge_hpd_notify() Reply-To: sashiko-reviews@lists.linux.dev To: "Jonas Karlman" Cc: neil.armstrong@linaro.org, linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, Frank.Li@kernel.org, imx@lists.linux.dev In-Reply-To: <20260516183838.2024991-18-jonas@kwiboo.se> References: <20260516183838.2024991-18-jonas@kwiboo.se> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 16 May 2026 19:52:24 +0000 Message-Id: <20260516195224.9E2CBC19425@smtp.kernel.org> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] Removing drm_bridge_hpd_notify() violates the DRM bridge API contr= act and causes hotplug events to be permanently lost during system suspend. -- commit 6b3491e39082015ab62431ea0c93c74c9344b995 Author: Jonas Karlman drm: bridge: dw_hdmi: Drop call to drm_bridge_hpd_notify() This commit removes the drm_bridge_hpd_notify() call from the dw_hdmi IRQ handler, relying instead only on drm_helper_hpd_irq_event() to avoid sending duplicate hotplug uevents to userspace. > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/= bridge/synopsys/dw-hdmi.c > index e9c4e24c090ca..6cc7b2a860bd8 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -3101,10 +3101,8 @@ static irqreturn_t dw_hdmi_irq(int irq, void *dev_= id) > status =3D=3D connector_status_connected ? > "plugin" : "plugout"); > =20 > - if (hdmi->bridge.dev) { > + if (hdmi->bridge.dev) > drm_helper_hpd_irq_event(hdmi->bridge.dev); > - drm_bridge_hpd_notify(&hdmi->bridge, status); > - } > } Will removing drm_bridge_hpd_notify() cause hotplug events to be permanently lost if they occur during system suspend? Since the driver advertises DRM_BRIDGE_OP_HPD, does the DRM bridge API contract still require it to call drm_bridge_hpd_notify() to properly propagate hotplug events to the rest of the bridge chain? Looking at drm_helper_hpd_irq_event(), it aborts early if polling is disabled: drivers/gpu/drm/drm_probe_helper.c:drm_helper_hpd_irq_event() { struct drm_connector *connector, *first_changed_connector =3D NULL; struct drm_connector_list_iter conn_iter; int changed =3D 0; if (!dev->mode_config.poll_enabled) return false; ... } During system suspend, drm_kms_helper_poll_disable() sets poll_enabled to false. If an HPD interrupt fires while the system is suspended, won't drm_helper_hpd_irq_event() silently drop the event without updating the connector status or scheduling any deferred work? Furthermore, when the system resumes, output_poll_execute() explicitly skips connectors that use the DRM_CONNECTOR_POLL_HPD flag, and the dw_hdmi resume handler does not appear to manually trigger a hotplug event check. Could this result in the system being completely unaware of any display connections or disconnections that happened while suspended, at least until a manual reprobe is forced by userspace? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260516183838.2024= 991-1-jonas@kwiboo.se?part=3D17 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D0D2CD4F3C for ; Sat, 16 May 2026 19:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CJpwgPMvWmDJGQPCx780cdY/gc6D4s9h7kHCO1CmlFM=; b=OCtCB8CpuPr2E4 2qANwQ2GuWYpWD/vCBjxfwjY3mprgM2nOYu54Je3KG2ZC6pwoVsJxn/sIFtt0fsL7FmYxdqVXP6BI M0ApXYiecJBW0vs6UO4Fa4G7eYZDN3s3zIFh8MaUZxkMK4+Yym5cQx7HpmjtlDJVj4mwt2bZuJw7D IMONFUzBcWG+VCnwaAvfe8/qQV4QQtIhIqC1+LtNQ3pcb8tcI+ZU32cKL22OnFWzIUiEW4toDn6Ja 48RAuH0wx3V/eKQ/FkRZzVsVyiYVA/zEpI0Cg+hXFfRYffaXR2LRR7OrvGRgcwnMGaF17cT9vQL0m 8lqxb7nNP6XrmRRsdO9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wOL3j-0000000BPZV-2dFS; Sat, 16 May 2026 19:52:27 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wOL3h-0000000BPZ7-3h9d for linux-amlogic@lists.infradead.org; Sat, 16 May 2026 19:52:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 3685E60141; Sat, 16 May 2026 19:52:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E2CBC19425; Sat, 16 May 2026 19:52:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778961144; bh=fAsWNGwQAqu+EJ+8N3R741IrNe5Q1D1pfyWbyfS013c=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=jkD+Pp0mnYYfYMurlZ0SylntRAn6adUMDneQodqK2Yynhiiqww3xyg206Mlm3OCmO Nx8Tca0M4muyaUFAKOzJ26mQsfG9ixOI5NQBxWGQsIy9uadf66v3Sf6vOgZwERq6ss iAnA1b4nyw1MOXw+DFw1j3BE76yIj1faGc+uFYDae1WRFeHvOs6ej4OHVkZVM/l2XJ U2IYcgAal+X+CjB2B1o1YOva8k0BdmDpyr+7dCWakTlrznZhLhb7zpwOdSbmxdQzNY P/jXi1/GzsDXfqYdR/1hhR5ckBnWXZt54xMDKn10YWfXgqdrrrqo0xoe1zQTtWUdgs aI6WaxiO6UAAQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 17/22] drm: bridge: dw_hdmi: Drop call to drm_bridge_hpd_notify() To: "Jonas Karlman" Cc: neil.armstrong@linaro.org, linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, Frank.Li@kernel.org, imx@lists.linux.dev In-Reply-To: <20260516183838.2024991-18-jonas@kwiboo.se> References: <20260516183838.2024991-18-jonas@kwiboo.se> Date: Sat, 16 May 2026 19:52:24 +0000 Message-Id: <20260516195224.9E2CBC19425@smtp.kernel.org> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIFJlbW92aW5nIGRybV9i cmlkZ2VfaHBkX25vdGlmeSgpIHZpb2xhdGVzIHRoZSBEUk0gYnJpZGdlIEFQSSBjb250cmFjdCBh bmQgY2F1c2VzIGhvdHBsdWcgZXZlbnRzIHRvIGJlIHBlcm1hbmVudGx5IGxvc3QgZHVyaW5nIHN5 c3RlbSBzdXNwZW5kLgotLQoKY29tbWl0IDZiMzQ5MWUzOTA4MjAxNWFiNjI0MzFlYTBjOTNjNzRj OTM0NGI5OTUKQXV0aG9yOiBKb25hcyBLYXJsbWFuIDxqb25hc0Brd2lib28uc2U+Cgpkcm06IGJy aWRnZTogZHdfaGRtaTogRHJvcCBjYWxsIHRvIGRybV9icmlkZ2VfaHBkX25vdGlmeSgpCgpUaGlz IGNvbW1pdCByZW1vdmVzIHRoZSBkcm1fYnJpZGdlX2hwZF9ub3RpZnkoKSBjYWxsIGZyb20gdGhl IGR3X2hkbWkgSVJRCmhhbmRsZXIsIHJlbHlpbmcgaW5zdGVhZCBvbmx5IG9uIGRybV9oZWxwZXJf aHBkX2lycV9ldmVudCgpIHRvIGF2b2lkIHNlbmRpbmcKZHVwbGljYXRlIGhvdHBsdWcgdWV2ZW50 cyB0byB1c2Vyc3BhY2UuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3N5 bm9wc3lzL2R3LWhkbWkuYyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3BzeXMvZHctaGRt aS5jCj4gaW5kZXggZTljNGUyNGMwOTBjYS4uNmNjN2IyYTg2MGJkOCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vYnJpZGdlL3N5bm9wc3lzL2R3LWhkbWkuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9icmlkZ2Uvc3lub3BzeXMvZHctaGRtaS5jCj4gQEAgLTMxMDEsMTAgKzMxMDEsOCBA QCBzdGF0aWMgaXJxcmV0dXJuX3QgZHdfaGRtaV9pcnEoaW50IGlycSwgdm9pZCAqZGV2X2lkKQo+ ICAJCQlzdGF0dXMgPT0gY29ubmVjdG9yX3N0YXR1c19jb25uZWN0ZWQgPwo+ICAJCQkicGx1Z2lu IiA6ICJwbHVnb3V0Iik7Cj4gIAo+IC0JCWlmIChoZG1pLT5icmlkZ2UuZGV2KSB7Cj4gKwkJaWYg KGhkbWktPmJyaWRnZS5kZXYpCj4gIAkJCWRybV9oZWxwZXJfaHBkX2lycV9ldmVudChoZG1pLT5i cmlkZ2UuZGV2KTsKPiAtCQkJZHJtX2JyaWRnZV9ocGRfbm90aWZ5KCZoZG1pLT5icmlkZ2UsIHN0 YXR1cyk7Cj4gLQkJfQo+ICAJfQoKV2lsbCByZW1vdmluZyBkcm1fYnJpZGdlX2hwZF9ub3RpZnko KSBjYXVzZSBob3RwbHVnIGV2ZW50cyB0byBiZSBwZXJtYW5lbnRseQpsb3N0IGlmIHRoZXkgb2Nj dXIgZHVyaW5nIHN5c3RlbSBzdXNwZW5kPwoKU2luY2UgdGhlIGRyaXZlciBhZHZlcnRpc2VzIERS TV9CUklER0VfT1BfSFBELCBkb2VzIHRoZSBEUk0gYnJpZGdlIEFQSQpjb250cmFjdCBzdGlsbCBy ZXF1aXJlIGl0IHRvIGNhbGwgZHJtX2JyaWRnZV9ocGRfbm90aWZ5KCkgdG8gcHJvcGVybHkKcHJv cGFnYXRlIGhvdHBsdWcgZXZlbnRzIHRvIHRoZSByZXN0IG9mIHRoZSBicmlkZ2UgY2hhaW4/CgpM b29raW5nIGF0IGRybV9oZWxwZXJfaHBkX2lycV9ldmVudCgpLCBpdCBhYm9ydHMgZWFybHkgaWYg cG9sbGluZyBpcwpkaXNhYmxlZDoKCmRyaXZlcnMvZ3B1L2RybS9kcm1fcHJvYmVfaGVscGVyLmM6 ZHJtX2hlbHBlcl9ocGRfaXJxX2V2ZW50KCkgewoJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5l Y3RvciwgKmZpcnN0X2NoYW5nZWRfY29ubmVjdG9yID0gTlVMTDsKCXN0cnVjdCBkcm1fY29ubmVj dG9yX2xpc3RfaXRlciBjb25uX2l0ZXI7CglpbnQgY2hhbmdlZCA9IDA7CgoJaWYgKCFkZXYtPm1v ZGVfY29uZmlnLnBvbGxfZW5hYmxlZCkKCQlyZXR1cm4gZmFsc2U7Ci4uLgp9CgpEdXJpbmcgc3lz dGVtIHN1c3BlbmQsIGRybV9rbXNfaGVscGVyX3BvbGxfZGlzYWJsZSgpIHNldHMgcG9sbF9lbmFi bGVkCnRvIGZhbHNlLiBJZiBhbiBIUEQgaW50ZXJydXB0IGZpcmVzIHdoaWxlIHRoZSBzeXN0ZW0g aXMgc3VzcGVuZGVkLCB3b24ndApkcm1faGVscGVyX2hwZF9pcnFfZXZlbnQoKSBzaWxlbnRseSBk cm9wIHRoZSBldmVudCB3aXRob3V0IHVwZGF0aW5nIHRoZQpjb25uZWN0b3Igc3RhdHVzIG9yIHNj aGVkdWxpbmcgYW55IGRlZmVycmVkIHdvcms/CgpGdXJ0aGVybW9yZSwgd2hlbiB0aGUgc3lzdGVt IHJlc3VtZXMsIG91dHB1dF9wb2xsX2V4ZWN1dGUoKSBleHBsaWNpdGx5IHNraXBzCmNvbm5lY3Rv cnMgdGhhdCB1c2UgdGhlIERSTV9DT05ORUNUT1JfUE9MTF9IUEQgZmxhZywgYW5kIHRoZSBkd19o ZG1pIHJlc3VtZQpoYW5kbGVyIGRvZXMgbm90IGFwcGVhciB0byBtYW51YWxseSB0cmlnZ2VyIGEg aG90cGx1ZyBldmVudCBjaGVjay4KCkNvdWxkIHRoaXMgcmVzdWx0IGluIHRoZSBzeXN0ZW0gYmVp bmcgY29tcGxldGVseSB1bmF3YXJlIG9mIGFueSBkaXNwbGF5CmNvbm5lY3Rpb25zIG9yIGRpc2Nv bm5lY3Rpb25zIHRoYXQgaGFwcGVuZWQgd2hpbGUgc3VzcGVuZGVkLCBhdCBsZWFzdCB1bnRpbAph IG1hbnVhbCByZXByb2JlIGlzIGZvcmNlZCBieSB1c2Vyc3BhY2U/CgotLSAKU2FzaGlrbyBBSSBy ZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwNTE2MTgzODM4LjIw MjQ5OTEtMS1qb25hc0Brd2lib28uc2U/cGFydD0xNwoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBtYWlsaW5nIGxpc3QKbGludXgt YW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo=