From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mauricio Faria de Oliveira <mfo@igalia.com>
Cc: Matthieu CASTET <castet.matthieu@free.fr>,
Stanislaw Gruszka <stf_xl@wp.pl>,
kernel-dev@igalia.com, linux-atm-general@lists.sourceforge.net,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: atm: ueagle-atm: adjust 'device found' message
Date: Sat, 16 May 2026 09:18:53 +0200 [thread overview]
Message-ID: <2026051628-squatter-stature-c0e0@gregkh> (raw)
In-Reply-To: <20260515-ueagle-atm_cosmetic-v1-1-9a15e5e45bd7@igalia.com>
On Fri, May 15, 2026 at 08:54:12PM -0300, Mauricio Faria de Oliveira wrote:
> Correct the verb form and add 'with' for clarity.
>
> Signed-off-by: Mauricio Faria de Oliveira <mfo@igalia.com>
> ---
> drivers/usb/atm/ueagle-atm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c
> index f3ae72feb5bfc313ccfa1ab6a9bb40fcd8f5800a..2730e7d41c89a354e115e38d97e314f888c62137 100644
> --- a/drivers/usb/atm/ueagle-atm.c
> +++ b/drivers/usb/atm/ueagle-atm.c
> @@ -2590,7 +2590,7 @@ static int uea_probe(struct usb_interface *intf, const struct usb_device_id *id)
> int ret;
>
> uea_enters(usb);
> - uea_info(usb, "ADSL device founded vid (%#X) pid (%#X) Rev (%#X): %s\n",
> + uea_info(usb, "ADSL device found with vid (%#X) pid (%#X) Rev (%#X): %s\n",
> le16_to_cpu(usb->descriptor.idVendor),
> le16_to_cpu(usb->descriptor.idProduct),
> le16_to_cpu(usb->descriptor.bcdDevice),
When drivers work properly, they are quiet, so that means this line
should be removed entirely.
thanks,
greg k-h
next prev parent reply other threads:[~2026-05-16 7:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 23:54 [PATCH 0/2] usb: atm: ueagle-atm: cosmetic changes to .probe() Mauricio Faria de Oliveira
2026-05-15 23:54 ` [PATCH 1/2] usb: atm: ueagle-atm: adjust 'device found' message Mauricio Faria de Oliveira
2026-05-16 7:18 ` Greg Kroah-Hartman [this message]
2026-05-15 23:54 ` [PATCH 2/2] usb: atm: ueagle-atm: add missing uea_leaves() in uea_probe() Mauricio Faria de Oliveira
2026-05-16 7:19 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026051628-squatter-stature-c0e0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=castet.matthieu@free.fr \
--cc=kernel-dev@igalia.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mfo@igalia.com \
--cc=stf_xl@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.