From: "Diego Fernando Mancera Gómez" <diegomancera.dev@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev,
"Diego Fernando Mancera Gómez" <diegomancera.dev@gmail.com>
Subject: [PATCH] staging: rtl8723bs: remove redundant comparison with true
Date: Sat, 16 May 2026 22:35:20 -0600 [thread overview]
Message-ID: <20260517043520.47423-1-diegomancera.dev@gmail.com> (raw)
Clean up the checkpatch.pl check: "Using comparison to true is
error prone". Evaluating the boolean variable directly is preferred
and more idiomatic in the Linux kernel.
Signed-off-by: Diego Fernando Mancera Gómez <diegomancera.dev@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
index 07a6db1d2..349b27f91 100644
--- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
+++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
@@ -531,7 +531,7 @@ u8 rtw_access_ctrl(struct adapter *padapter, u8 *mac_addr)
paclnode = list_entry(plist, struct rtw_wlan_acl_node, list);
if (!memcmp(paclnode->addr, mac_addr, ETH_ALEN))
- if (paclnode->valid == true) {
+ if (paclnode->valid) {
match = true;
break;
}
--
2.43.0
next reply other threads:[~2026-05-17 4:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 4:35 Diego Fernando Mancera Gómez [this message]
2026-05-21 10:41 ` [PATCH] staging: rtl8723bs: remove redundant comparison with true Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260517043520.47423-1-diegomancera.dev@gmail.com \
--to=diegomancera.dev@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.