All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: shayderrr <darknessshayder@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: octeon: fix carrier state, null guard, and modernize phy ioctl
Date: Sun, 17 May 2026 16:43:36 +0200	[thread overview]
Message-ID: <2026051706-grab-overstep-66d4@gregkh> (raw)
In-Reply-To: <20260517141955.79666-1-darknessshayder@gmail.com>

On Sun, May 17, 2026 at 09:19:55AM -0500, shayderrr wrote:
> From: Pranav Bajjuri <darknessshayder@gmail.com>
> 
> Add netif_carrier_off() to cvm_oct_common_stop(), guard
> cvm_oct_adjust_link() against null phydev, replace open-coded
> ioctl checks with phy_do_ioctl_running(), and zero priv->link_info
> on stop alongside last_link.

I am sorry, but I do not understand any of this.  Please always only do
one logical thing per patch.  This should be a patch series, right?

And have you tested this?

thanks,

greg k-h

  reply	other threads:[~2026-05-17 14:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-17 14:19 [PATCH] net: octeon: fix carrier state, null guard, and modernize phy ioctl shayderrr
2026-05-17 14:43 ` Greg KH [this message]
     [not found]   ` <CANy=CjfYXx+S0o7R60TDkm6ZLifsJ9P4nDoy9JPKvWB0NpgBBg@mail.gmail.com>
2026-05-18  5:12     ` Greg KH
2026-05-17 19:00 ` kernel test robot
2026-05-17 21:45 ` kernel test robot
2026-05-18  5:54 ` Dan Carpenter
2026-05-18  5:55   ` Dan Carpenter
2026-05-18  5:59     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026051706-grab-overstep-66d4@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=darknessshayder@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.