From: "Diego Fernando Mancera Gómez" <diegomancera.dev@gmail.com>
To: thierry.reding@kernel.org, jonathanh@nvidia.com,
skomatineni@nvidia.com, luca.ceresoli@bootlin.com,
gregkh@linuxfoundation.org
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-staging@lists.linux.dev,
"Diego Fernando Mancera Gómez" <diegomancera.dev@gmail.com>
Subject: [PATCH] staging: media: tegra-video: prefer using the BIT macro
Date: Sun, 17 May 2026 00:05:11 -0600 [thread overview]
Message-ID: <20260517060511.231437-1-diegomancera.dev@gmail.com> (raw)
Replace open-coded bit shifts (1 << 28) with the standard kernel BIT
macro. This improves code uniformity, matches style guidelines, and
prevents accidental signed overflow issues.
Signed-off-by: Diego Fernando Mancera Gómez <diegomancera.dev@gmail.com>
---
drivers/staging/media/tegra-video/tegra20.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/tegra-video/tegra20.c b/drivers/staging/media/tegra-video/tegra20.c
index e513e6ccb..08fa234af 100644
--- a/drivers/staging/media/tegra-video/tegra20.c
+++ b/drivers/staging/media/tegra-video/tegra20.c
@@ -177,7 +177,7 @@ enum tegra_vi_out {
#define CSI_SKIP_PACKET_THRESHOLD(n) (((n) & 0xff) << 16)
#define TEGRA_CSI_PIXEL_STREAM_CONTROL0(n) (0x0018 + (n) * 0x2c)
#define CSI_PP_PAD_FRAME_PAD0S (0 << 28)
-#define CSI_PP_PAD_FRAME_PAD1S (1 << 28)
+#define CSI_PP_PAD_FRAME_PAD1S BIT(28)
#define CSI_PP_PAD_FRAME_NOPAD (2 << 28)
#define CSI_PP_HEADER_EC_ENABLE BIT(27)
#define CSI_PP_PAD_SHORT_LINE_PAD0S (0 << 24)
--
2.43.0
next reply other threads:[~2026-05-17 6:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 6:05 Diego Fernando Mancera Gómez [this message]
2026-05-18 5:08 ` [PATCH] staging: media: tegra-video: prefer using the BIT macro Dan Carpenter
2026-05-18 6:04 ` Diego Fernando Mancera Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260517060511.231437-1-diegomancera.dev@gmail.com \
--to=diegomancera.dev@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=mchehab@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.