diff for duplicates of <202605171045.6jPun4QF-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 808d4d4..4d58a00 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,13 +1,6 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -TO: Miri Korenblit <miriam.rachel.korenblit@intel.com> -CC: Johannes Berg <johannes.berg@intel.com> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git next head: ce2b645bb3099ef4d96759335271e25875202ce9 commit: d751c944055aedf33a6cab9b1cadaab65d7bc8dd [13/93] wifi: iwlwifi: mld: use host rate for NAN management frames -:::::: branch date: 7 hours ago -:::::: commit date: 5 days ago config: i386-randconfig-141-20260517 (https://download.01.org/0day-ci/archive/20260517/202605171045.6jPun4QF-lkp@intel.com/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) smatch: v0.5.0-9185-gbcc58b9c @@ -23,7 +16,6 @@ drivers/net/wireless/intel/iwlwifi/mld/tx.c:571 iwl_mld_fill_tx_cmd() warn: vari vim +/mld_sta +571 drivers/net/wireless/intel/iwlwifi/mld/tx.c -d1e879ec600f9b3 Miri Korenblit 2025-02-16 537 d1e879ec600f9b3 Miri Korenblit 2025-02-16 538 static void d1e879ec600f9b3 Miri Korenblit 2025-02-16 539 iwl_mld_fill_tx_cmd(struct iwl_mld *mld, struct sk_buff *skb, d1e879ec600f9b3 Miri Korenblit 2025-02-16 540 struct iwl_device_tx_cmd *dev_tx_cmd, @@ -52,12 +44,18 @@ d751c944055aedf Miri Korenblit 2026-05-10 562 * - when no sta is given. d751c944055aedf Miri Korenblit 2026-05-10 563 * - frames that are sent to an NMI sta, which is only used for management. d1e879ec600f9b3 Miri Korenblit 2025-02-16 564 */ d751c944055aedf Miri Korenblit 2026-05-10 @565 if (unlikely(!sta || mld_sta->vif->type == NL80211_IFTYPE_NAN || + ^^^^^^^^^^^^^^^^^^ +Dereference + d1e879ec600f9b3 Miri Korenblit 2025-02-16 566 info->control.flags & IEEE80211_TX_CTRL_RATE_INJECT)) { d1e879ec600f9b3 Miri Korenblit 2025-02-16 567 flags |= IWL_TX_FLAGS_CMD_RATE; d1e879ec600f9b3 Miri Korenblit 2025-02-16 568 rate_n_flags = iwl_mld_get_tx_rate_n_flags(mld, info, sta, d1e879ec600f9b3 Miri Korenblit 2025-02-16 569 hdr->frame_control); d1e879ec600f9b3 Miri Korenblit 2025-02-16 570 } else if (!ieee80211_is_data(hdr->frame_control) || d1e879ec600f9b3 Miri Korenblit 2025-02-16 @571 (mld_sta && + ^^^^^^^ +Checked too late. + d1e879ec600f9b3 Miri Korenblit 2025-02-16 572 mld_sta->sta_state < IEEE80211_STA_AUTHORIZED)) { d1e879ec600f9b3 Miri Korenblit 2025-02-16 573 /* These are important frames */ d1e879ec600f9b3 Miri Korenblit 2025-02-16 574 flags |= IWL_TX_FLAGS_HIGH_PRI; @@ -76,13 +74,6 @@ d1e879ec600f9b3 Miri Korenblit 2025-02-16 586 tx_cmd->flags = cpu_to_le16(fla d1e879ec600f9b3 Miri Korenblit 2025-02-16 587 dabc88cb3b78c0d Johannes Berg 2025-05-05 588 tx_cmd->rate_n_flags = rate_n_flags; d1e879ec600f9b3 Miri Korenblit 2025-02-16 589 } -d1e879ec600f9b3 Miri Korenblit 2025-02-16 590 - -:::::: The code at line 571 was first introduced by commit -:::::: d1e879ec600f9b3bdd253167533959facfefb17b wifi: iwlwifi: add iwlmld sub-driver - -:::::: TO: Miri Korenblit <miriam.rachel.korenblit@intel.com> -:::::: CC: Johannes Berg <johannes.berg@intel.com> -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 26d2d87..ad09b12 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,21 +1,16 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0[iwlwifi-next:next 13/93] drivers/net/wireless/intel/iwlwifi/mld/tx.c:571 iwl_mld_fill_tx_cmd() warn: variable dereferenced before check 'mld_sta' (see line 565)\0" - "Date\0Sun, 17 May 2026 10:25:42 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Mon, 18 May 2026 08:03:27 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Miri Korenblit <miriam.rachel.korenblit@intel.com>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + oe-kbuild-all@lists.linux.dev + " Johannes Berg <johannes.berg@intel.com>\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "TO: Miri Korenblit <miriam.rachel.korenblit@intel.com>\n" - "CC: Johannes Berg <johannes.berg@intel.com>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git next\n" "head: ce2b645bb3099ef4d96759335271e25875202ce9\n" "commit: d751c944055aedf33a6cab9b1cadaab65d7bc8dd [13/93] wifi: iwlwifi: mld: use host rate for NAN management frames\n" - ":::::: branch date: 7 hours ago\n" - ":::::: commit date: 5 days ago\n" "config: i386-randconfig-141-20260517 (https://download.01.org/0day-ci/archive/20260517/202605171045.6jPun4QF-lkp@intel.com/config)\n" "compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)\n" "smatch: v0.5.0-9185-gbcc58b9c\n" @@ -31,7 +26,6 @@ "\n" "vim +/mld_sta +571 drivers/net/wireless/intel/iwlwifi/mld/tx.c\n" "\n" - "d1e879ec600f9b3 Miri Korenblit 2025-02-16 537 \n" "d1e879ec600f9b3 Miri Korenblit 2025-02-16 538 static void\n" "d1e879ec600f9b3 Miri Korenblit 2025-02-16 539 iwl_mld_fill_tx_cmd(struct iwl_mld *mld, struct sk_buff *skb,\n" "d1e879ec600f9b3 Miri Korenblit 2025-02-16 540 \t\t struct iwl_device_tx_cmd *dev_tx_cmd,\n" @@ -60,12 +54,18 @@ "d751c944055aedf Miri Korenblit 2026-05-10 563 \t * - frames that are sent to an NMI sta, which is only used for management.\n" "d1e879ec600f9b3 Miri Korenblit 2025-02-16 564 \t */\n" "d751c944055aedf Miri Korenblit 2026-05-10 @565 \tif (unlikely(!sta || mld_sta->vif->type == NL80211_IFTYPE_NAN ||\n" + " ^^^^^^^^^^^^^^^^^^\n" + "Dereference\n" + "\n" "d1e879ec600f9b3 Miri Korenblit 2025-02-16 566 \t\t info->control.flags & IEEE80211_TX_CTRL_RATE_INJECT)) {\n" "d1e879ec600f9b3 Miri Korenblit 2025-02-16 567 \t\tflags |= IWL_TX_FLAGS_CMD_RATE;\n" "d1e879ec600f9b3 Miri Korenblit 2025-02-16 568 \t\trate_n_flags = iwl_mld_get_tx_rate_n_flags(mld, info, sta,\n" "d1e879ec600f9b3 Miri Korenblit 2025-02-16 569 \t\t\t\t\t\t\t hdr->frame_control);\n" "d1e879ec600f9b3 Miri Korenblit 2025-02-16 570 \t} else if (!ieee80211_is_data(hdr->frame_control) ||\n" "d1e879ec600f9b3 Miri Korenblit 2025-02-16 @571 \t\t (mld_sta &&\n" + " ^^^^^^^\n" + "Checked too late.\n" + "\n" "d1e879ec600f9b3 Miri Korenblit 2025-02-16 572 \t\t mld_sta->sta_state < IEEE80211_STA_AUTHORIZED)) {\n" "d1e879ec600f9b3 Miri Korenblit 2025-02-16 573 \t\t/* These are important frames */\n" "d1e879ec600f9b3 Miri Korenblit 2025-02-16 574 \t\tflags |= IWL_TX_FLAGS_HIGH_PRI;\n" @@ -84,16 +84,9 @@ "d1e879ec600f9b3 Miri Korenblit 2025-02-16 587 \n" "dabc88cb3b78c0d Johannes Berg 2025-05-05 588 \ttx_cmd->rate_n_flags = rate_n_flags;\n" "d1e879ec600f9b3 Miri Korenblit 2025-02-16 589 }\n" - "d1e879ec600f9b3 Miri Korenblit 2025-02-16 590 \n" - "\n" - ":::::: The code at line 571 was first introduced by commit\n" - ":::::: d1e879ec600f9b3bdd253167533959facfefb17b wifi: iwlwifi: add iwlmld sub-driver\n" - "\n" - ":::::: TO: Miri Korenblit <miriam.rachel.korenblit@intel.com>\n" - ":::::: CC: Johannes Berg <johannes.berg@intel.com>\n" "\n" "--\n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -70e846c48027289cf1328035cce242bc27bbea7899c1eac9a8706e1f957a00e7 +00d2a37af1116aa5bb5dcf48f19b8616496eb2a325575cbd47a13aa0ad90219a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.