From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2D31234994 for ; Sun, 17 May 2026 13:01:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779022912; cv=none; b=N7pbIJH2+ZlSfzB2m6iUmsY+lZF+sk7sx3IXBryRW/cm2EBDqpvSsdfFP7s3SX0+VYkIpTTcqo3W+WRY3vMUpqn+NgSLpciO25vvGoq3R2FtX8qaMCtJ1eXsoXfIgzmQZ6q9jLwLWy1efGWfc+8wlI/DcWoaT2w67tS4OqZp00E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779022912; c=relaxed/simple; bh=A70iFFKqwBzNbP1gZiTI6yxiFqetCwVFR69Kws36fmM=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=rhzV2eXXeDHjQvA2+wQ6F1aAXlPAwgSCPbfXAtLVjj547t79fqQj/HumpqeAcUguS4cBCLlE0C2oHoXq2zfSXBCiIoarXqgvQcr2uHlvDPnB4dMtMkWRaNpV8y1d9QsGXvTwkL8r4fv74pg4AQREo3+0nZgmfq3oSdzt6jE77Kk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qzd6s5pJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qzd6s5pJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 247F4C2BCB8; Sun, 17 May 2026 13:01:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779022910; bh=A70iFFKqwBzNbP1gZiTI6yxiFqetCwVFR69Kws36fmM=; h=Date:From:To:Cc:Subject:References:From; b=qzd6s5pJx1VZaj4k5ccGyAArjr8tvdxfBNS68xjsZM/t/OXFd5yGB5+6yKsh8SgVG xcGmve75N2rZRrWzT4X3imdMtZ93/LV6mw4zaTVIAbpVuU9MV+R1o8SBoHtpK9ba++ aoLos3F/67MSYGBYhs3AKRiE1yOO3X5IWRZ+Fo5sUNlkl5DcF/ZpX7UNNec9U0Tq/y Ouj6lmGqUI6OiPgP5jkrrCnVPQDCqr7HnRxFP7ZaLPwAvzofELbJC+Ik5RH0scDm/u /cYsts6vcXPbUImWsvN5wv/sFbpZmp40E5Y4brjGD/z6VdAwka1BChZMOvwibqXpym Em+Bp88qsD7FA== Received: from rostedt by gandalf with local (Exim 4.99.2) (envelope-from ) id 1wOb86-00000002syr-1vZF; Sun, 17 May 2026 09:02:02 -0400 Message-ID: <20260517130202.310048748@kernel.org> User-Agent: quilt/0.69 Date: Sun, 17 May 2026 09:01:52 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Sashiko , Vincent Donnefort Subject: [for-linus][PATCH 2/2] tracing: Fix desc in error path for the trace remote test module References: <20260517130150.399923268@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 From: Vincent Donnefort During initialisation in remote_test_load(), if one of the simple_ring_buffer fails to initialise, the error path attempts to rollback initialised buffers. However, the rollback incorrectly uses the global pointer to the trace descriptor, which is only set upon successful load completion. Fix the error path by using the local pointer to the descriptor. Link: https://patch.msgid.link/20260515201616.337469-1-vdonnefort@google.com Fixes: ea908a2b79c8 ("tracing: Add a trace remote module for testing") Reported-by: Sashiko Signed-off-by: Vincent Donnefort base-commit: 5d6919055dec134de3c40167a490f33c74c12581 Signed-off-by: Steven Rostedt --- kernel/trace/remote_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/trace/remote_test.c b/kernel/trace/remote_test.c index 6c1b7701ddae..a3e2c9b606eb 100644 --- a/kernel/trace/remote_test.c +++ b/kernel/trace/remote_test.c @@ -110,9 +110,9 @@ static struct trace_buffer_desc *remote_test_load(unsigned long size, void *unus return remote_test_buffer_desc; err_unload: - for_each_ring_buffer_desc(rb_desc, cpu, remote_test_buffer_desc) + for_each_ring_buffer_desc(rb_desc, cpu, desc) remote_test_unload_simple_rb(rb_desc->cpu); - trace_remote_free_buffer(remote_test_buffer_desc); + trace_remote_free_buffer(desc); err_free_desc: kfree(desc); -- 2.53.0