From: SeongJae Park <sj@kernel.org>
To: SeongJae Park <sj@kernel.org>
Cc: "# 6 . 2 . x" <stable@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [RFC PATCH v2] mm/damon/sysfs-schemes: delete tried region in regions_rmdirs()
Date: Sun, 17 May 2026 10:52:17 -0700 [thread overview]
Message-ID: <20260517175218.2272-1-sj@kernel.org> (raw)
In-Reply-To: <20260517172624.888-1-sj@kernel.org>
On Sun, 17 May 2026 10:26:21 -0700 SeongJae Park <sj@kernel.org> wrote:
> DAMON sysfs maintains the DAMOS tried region directory objects via a
> linked list. When the user requests refresh of the directories, DAMON
> sysfs removes all the region directories first, and then generate
> updated regions directory on the empty space. The removal function
> (damon_sysfs_scheme_regions_rm_dirs()) only puts the kobj objects.
> Deletion of the container region object from the linked list is done
> inside the kobj release callback function.
>
> If somehow the callback invocation is delayed, the list will contain
> regions list that gonna be freed. If the updated region directories
> creation is started in this situation, the list can be corrupted and
> use-after-free can happen.
>
> Because the kobj objects are managed by only DAMON sysfs, the issue
> cannot happen in normal situation. But, such delays can be made on
> kernels that built with CONFIG_DEBUG_KOBJECT_RELEASE. On the kernel,
> the issue can indeed be reproduced like below.
>
> # damo start --damos_action stat
> # cd /sys/kernel/mm/damon/admin/kdamonds/0/
> # for i in {1..10}; do echo update_schemes_tried_regions > state; done
> # dmesg | grep underflow
> [ 89.296152] refcount_t: underflow; use-after-free.
>
> Fix the issue by removing the region object from the list when
> decrementing the reference count.
>
> Also update damos_sysfs_populate_region_dir() to add the region object
> to the list only after the kobject_init_and_add() is success, so that
> fail of kobject_init_and_add() is not leaving the deallocated object on
> the list.
>
> The issue was discovered [1] by Sashiko.
>
> [1] https://lore.kernel.org/20260513011920.119183-1-sj@kernel.org
Sashiko failed reviewing [1] this, due to the not-yet-updsated mm-new tree
baseline problem [2]. I will rebase this to mm-stable and repost.
[1] https://sashiko.dev/#/patchset/20260517172624.888-1-sj%40kernel.org
[2] https://lore.kernel.org/20260514205555.51653-1-sj@kernel.org/
Thanks,
SJ
[...]
prev parent reply other threads:[~2026-05-17 17:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 17:26 [RFC PATCH v2] mm/damon/sysfs-schemes: delete tried region in regions_rmdirs() SeongJae Park
2026-05-17 17:52 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260517175218.2272-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.