All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Nicolas Schier <nsc@kernel.org>,
	Andrew Jones <andrew.jones@linux.dev>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kconfig: add kconfig-sym-check static checker
Date: Sun, 17 May 2026 11:50:00 -1000	[thread overview]
Message-ID: <20260517215000.GA1202663@ax162> (raw)
In-Reply-To: <agmRSOEqwmgGJH_K@ashevche-desk.local>

On Sun, May 17, 2026 at 12:58:32PM +0300, Andy Shevchenko wrote:
> On Sun, May 17, 2026 at 06:11:28PM +0900, Nathan Chancellor wrote:
> > but I
> > am not sure that it is an obvious one in the grand scheme of things.
> > 
> >   $ hyperfine 'git ls-files "*Kconfig*"' 'find . -name "*Kconfig*"'
> 
> Does this makes caches cold before *each* attempt?

No but if I do so via the '--prepare' option, I see a similar
difference.

> >   Benchmark 1: git ls-files "*Kconfig*"
> >     Time (mean ± σ):      24.6 ms ±   1.0 ms    [User: 18.0 ms, System: 6.1 ms]
> >     Range (min … max):    20.5 ms …  28.7 ms    120 runs
> > 
> >   Benchmark 2: find . -name "*Kconfig*"
> >     Time (mean ± σ):     222.9 ms ±   4.5 ms    [User: 80.6 ms, System: 140.1 ms]
> >     Range (min … max):   216.0 ms … 227.6 ms    13 runs
> > 
> >   Summary
> >     git ls-files "*Kconfig*" ran
> >       9.06 ± 0.43 times faster than find . -name "*Kconfig*"
> > 
> > But I don't know how complicated such checking is in Perl, so I would be
> > willing to see what it looks like.
> 
> 1. Call `git ls-files`,
> 2. if the above fails, call `find`.
> 3. `find` never fails (okay... :-)
> 
> In any language it shouldn't be much code.

Yeah, I guess I would look for '.git' before calling 'git ls-files' but
that should work as well. It's up to Andrew.

-- 
Cheers,
Nathan

      reply	other threads:[~2026-05-17 21:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 21:03 [PATCH] kconfig: add kconfig-sym-check static checker Andrew Jones
2026-05-13 21:44 ` Andy Shevchenko
2026-05-13 23:31 ` Randy Dunlap
2026-05-14 13:32 ` Nathan Chancellor
2026-05-14 13:51   ` Andrew Jones
2026-05-14 15:26   ` Julian Braha
2026-05-14 16:01     ` Nathan Chancellor
2026-05-15 19:08   ` Nicolas Schier
2026-05-17  4:26     ` Nathan Chancellor
2026-05-17  6:14       ` Andy Shevchenko
2026-05-17  9:11         ` Nathan Chancellor
2026-05-17  9:58           ` Andy Shevchenko
2026-05-17 21:50             ` Nathan Chancellor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260517215000.GA1202663@ax162 \
    --to=nathan@kernel.org \
    --cc=andrew.jones@linux.dev \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nsc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.