From: "Mickaël Salaün" <mic@digikod.net>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: "Günther Noack" <gnoack@google.com>,
"kernel test robot" <oliver.sang@intel.com>,
linux-security-module@vger.kernel.org, oe-lkp@lists.linux.dev,
lkp@intel.com, linux-kernel@vger.kernel.org,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Kees Cook" <kees@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [linus:master] [selftests] 465b05bae5: kernel-selftests.landlock.audit_test.audit.tsync_override_log_subdomains_off.fail
Date: Mon, 18 May 2026 11:30:42 +0200 [thread overview]
Message-ID: <20260518.ohn9DahGhui6@digikod.net> (raw)
In-Reply-To: <20260518100602-5b161e99-83fa-4170-bb7b-1642df6b5a3d@linutronix.de>
On Mon, May 18, 2026 at 10:48:27AM +0200, Thomas Weißschuh wrote:
> On Wed, May 13, 2026 at 12:52:35PM +0200, Mickaël Salaün wrote:
> (...)
>
> > > > config: x86_64-rhel-9.4-kselftests
> > > > compiler: gcc-14
> > > > test machine: 16 threads Intel(R) Core(TM) i7-13620H (Raptor Lake) with 32G memory
> > > >
> > > > (please refer to attached dmesg/kmsg for entire log/backtrace)
> > > >
> > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > > the same patch/commit), kindly add following tags
> > > > | Reported-by: kernel test robot <oliver.sang@intel.com>
> > > > | Closes: https://lore.kernel.org/oe-lkp/202605111649.a8b30a62-lkp@intel.com
> > >
> > > I was unable to run the landlock selftests myself, on my machines they are
> > > failing at runtime with all kinds of colorful errors. Are the requirements
> > > explained somewhere?
> >
> > I'm curious about the errors you get. They are standard kselftests that
> > should work following this workflow:
> >
> > make TARGETS=landlock O=build kselftest-gen_tar
> >
> > and then running ./build/kselftests/kselftest_install/run_kselftest.sh
> > as root in a VM. The required kernel configuration is listed in
> > tools/testing/selftests/landlock/config
>
> So there are two root issues I ran into:
>
> 1) The tests can not be executed from virtiofs (as set up by virtme-ng):
Most filesystem tests initially set up tmpfs and then use it.
I'm using virtme-ng too, see the
https://github.com/landlock-lsm/landlock-test-tools
ARCH=x86_64 .../check-linux.sh build_light kselftest
>
> # RUN audit.layers ...
> # audit_test.c:52:layers:Expected 0 (0) <= self->audit_fd (-13)
> # audit_test.c:61:layers:Failed to initialize audit: Permission denied
> # layers: Test failed
> # FAIL audit.layers
> not ok 1 audit.layers
>
> (The same for all other testcases)
It looks like the tests are not run with enough privileges. Do you run
them as root? Does the kernel has the required config set?
>
> 2) $PWD needs to be the test binary directory for "./wait-pipe-sandbox" to work.
Yes. run_kselftest.sh should handle that.
>
> > To make it easier, we wrote a wrapper to test everything with UML:
> > https://github.com/landlock-lsm/landlock-test-tools (see check-linux.sh)
> >
> > >
> > > > # # RUN audit.tsync_override_log_subdomains_off ...
> > > > # # audit_test.c:591:tsync_override_log_subdomains_off:Expected 0 (0) == matches_log_signal(_metadata, self->audit_fd, child_data.parent_pid, NULL) (-11)
> > >
> > > This error number means "EAGAIN 11 Resource temporarily unavailable",
> > > so it could be a temporary error.
> >
> > Yes, the test is flaky under pressure.
> >
> > >
> > > Can you reproduce this issue? Is it really dependent on my patch as
> > > blamed above? If so, does the selftest rely on the previous, incorrect order?
> >
> > I don't think it directly depends on your patch but it might be a side
> > effect. Anyway, I've been working on fixing this kind of issue and just
> > sent a fix:
> > https://lore.kernel.org/r/20260513105112.140137-2-mic@digikod.net
>
> Thanks, unfortunately I can't validate that it will fix the issue at hand.
I pushed it to -next, we'll see but I'm pretty sure this is the issue.
next prev parent reply other threads:[~2026-05-18 9:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 14:15 [linus:master] [selftests] 465b05bae5: kernel-selftests.landlock.audit_test.audit.tsync_override_log_subdomains_off.fail kernel test robot
2026-05-12 9:27 ` Thomas Weißschuh
2026-05-13 10:52 ` Mickaël Salaün
2026-05-18 8:48 ` Thomas Weißschuh
2026-05-18 9:30 ` Mickaël Salaün [this message]
2026-05-18 10:01 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518.ohn9DahGhui6@digikod.net \
--to=mic@digikod.net \
--cc=gnoack@google.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=skhan@linuxfoundation.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.