From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ramanaidu.naladala@intel.com, jani.nikula@intel.com,
Jeevan B <jeevan.b@intel.com>
Subject: [PATCH i-g-t 2/2] tests/kms_cursor_legacy: Use preferred modifier for non-cursor framebuffers
Date: Mon, 18 May 2026 14:16:31 +0530 [thread overview]
Message-ID: <20260518084631.1085515-3-jeevan.b@intel.com> (raw)
In-Reply-To: <20260518084631.1085515-1-jeevan.b@intel.com>
Stop hardcoding DRM_FORMAT_MOD_LINEAR for primary test framebuffers.
Instead, use IGT_FORMAT_MOD_PREFERRED. This allows IGT to select a
tiling mode supported by the platform via capability checks, avoiding
per-platform modifier policies in tests as tiling support evolves.
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/kms_cursor_legacy.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
index 5399ef481..d281ffd9c 100644
--- a/tests/kms_cursor_legacy.c
+++ b/tests/kms_cursor_legacy.c
@@ -373,7 +373,7 @@ static void set_fb_on_crtc(igt_display_t *display, igt_crtc_t *crtc,
igt_create_pattern_fb(display->drm_fd,
mode->hdisplay, mode->vdisplay,
- DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, fb_info);
+ DRM_FORMAT_XRGB8888, IGT_FORMAT_MOD_PREFERRED, fb_info);
primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
igt_plane_set_fb(primary, fb_info);
@@ -605,7 +605,8 @@ static void prepare_flip_test(igt_display_t *display,
crtc->planes[1].type != DRM_PLANE_TYPE_CURSOR);
igt_create_color_pattern_fb(display->drm_fd, prim_fb->width, prim_fb->height,
- DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR, .1, .1, .1, argb_fb);
+ DRM_FORMAT_ARGB8888, IGT_FORMAT_MOD_PREFERRED,
+ .1, .1, .1, argb_fb);
}
}
@@ -1709,7 +1710,8 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)
set_fb_on_crtc(display, crtc, output, &fb_info[0]);
plane_primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
igt_create_color_pattern_fb(display->drm_fd, fb_info[0].width, fb_info[0].height,
- DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, .1, .1, .1, &fb_info[1]);
+ DRM_FORMAT_XRGB8888, IGT_FORMAT_MOD_PREFERRED,
+ .1, .1, .1, &fb_info[1]);
igt_create_color_fb(display->drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
DRM_FORMAT_MOD_LINEAR, 1., 1., 1., &cursor_fb);
--
2.43.0
next prev parent reply other threads:[~2026-05-18 8:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 8:46 [PATCH i-g-t 0/2] Add preferred FB modifier helper Jeevan B
2026-05-18 8:46 ` [PATCH i-g-t 1/2] lib/igt_fb: Add IGT_FORMAT_MOD_PREFERRED helper modifier Jeevan B
2026-05-18 8:46 ` Jeevan B [this message]
2026-05-19 0:30 ` ✓ Xe.CI.BAT: success for Add preferred FB modifier helper Patchwork
2026-05-19 0:52 ` ✓ i915.CI.BAT: " Patchwork
2026-05-19 7:05 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-05-19 20:06 ` ✓ i915.CI.Full: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518084631.1085515-3-jeevan.b@intel.com \
--to=jeevan.b@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=ramanaidu.naladala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.