From: Bin Guo <guobin@linux.alibaba.com>
To: qemu-devel@nongnu.org
Cc: peterx@redhat.com, farosas@suse.de
Subject: [PATCH 1/8] migration/fd: collapse migration_fd_valid into single boolean expression
Date: Mon, 18 May 2026 18:51:48 +0800 [thread overview]
Message-ID: <20260518105156.17626-2-guobin@linux.alibaba.com> (raw)
In-Reply-To: <20260518105156.17626-1-guobin@linux.alibaba.com>
Two if/return-true blocks followed by a final return false
are equivalent to a single OR-expression and easier to scan.
Signed-off-by: Bin Guo <guobin@linux.alibaba.com>
---
migration/fd.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/migration/fd.c b/migration/fd.c
index f05f95992f..939cdda4e1 100644
--- a/migration/fd.c
+++ b/migration/fd.c
@@ -39,15 +39,7 @@ static bool fd_is_pipe(int fd)
static bool migration_fd_valid(int fd)
{
- if (fd_is_socket(fd)) {
- return true;
- }
-
- if (fd_is_pipe(fd)) {
- return true;
- }
-
- return false;
+ return fd_is_socket(fd) || fd_is_pipe(fd);
}
QIOChannel *fd_connect_outgoing(MigrationState *s, const char *fdname,
--
2.50.1 (Apple Git-155)
next prev parent reply other threads:[~2026-05-18 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 10:51 [PATCH 0/8] migration: cleanups, fixes and micro-optimizations Bin Guo
2026-05-18 10:51 ` Bin Guo [this message]
2026-05-18 10:51 ` [PATCH 2/8] migration/global_state: replace strcpy("") with explicit NUL termination Bin Guo
2026-05-18 10:51 ` [PATCH 3/8] migration/vmstate: avoid per-element heap churn in vmsd ptr marker field Bin Guo
-- strict thread matches above, loose matches on Subject: below --
2026-05-18 11:01 [PATCH 0/8] migration: cleanups, fixes and micro-optimizations Bin Guo
2026-05-18 11:01 ` [PATCH 1/8] migration/fd: collapse migration_fd_valid into single boolean expression Bin Guo
2026-05-18 20:22 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518105156.17626-2-guobin@linux.alibaba.com \
--to=guobin@linux.alibaba.com \
--cc=farosas@suse.de \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.