From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AACA313E3B for ; Mon, 18 May 2026 11:49:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779104972; cv=none; b=C+KoI4QC3nORnmDfetKeeaLmDQ/5IPAaHkvShT5MAVU9asSodhp6GLYlYEcfL/1pr3fZbpkGk1cz3HBh0S6k96wPFl8sXEGjGbTrBfjz9aOpNixlVUeeg9ykOHItpqPASQdEyoqJvnF2yMznyG4EbVqg6kYUGkniZX30mdWrqvM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779104972; c=relaxed/simple; bh=cNlP5bfLoARIVy4MMsIn8cjA7BGxZtEfDS9gueb1MFQ=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=JinHeW1XxH9JmA0BiAydRBuUxKf32pQFg0Gdj4AWM7CZQ99c2BnWUkNXrXobzoA07YWjdKUbKwFDRzvK1UUkcutFBen/rC4ZGOnabrIhXp/dI9XbzOPhYm0GbwLxfHL/F3GZcOyxnIltf7xkabomnU44wwso+NtolZwdFKdVyFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Rs/hRu1q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Rs/hRu1q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7A0DC2BCB7; Mon, 18 May 2026 11:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779104972; bh=cNlP5bfLoARIVy4MMsIn8cjA7BGxZtEfDS9gueb1MFQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=Rs/hRu1qd3MCaspgLiBSjcA/qG4kUU2J/m7lnjr/SRbCzFfdSvBd6BenDY4aMH7La xGlD6dkffEZMUqvRRWJNqPHqeRTe+5XfuHcXTAKgCL1DY6kMtqIGAQa2pNmKCjdbD/ LJWIWXxTk0nhYLhSBETkEys+9ozsnI1M6hDSEnimIiVw1PB3v1uHk59BVbf/0zCC7M WRKd1wFDoeThIH1lExSgs7ss/snbopBtetIfz3PesUsW2DuhEKJHVim4QwZRb7CtDG lnn8gNZQrpl5eolIFOmj3lDPfUm/kscuHs6PupRDwfFFIqh2fzkQ3bNPuP7bF0ZvD8 JNw5THfcfublQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH 4/5] phy: qualcomm: qmp-combo: Add USB4/TBT3 configuration data for Hamoa Reply-To: sashiko-reviews@lists.linux.dev To: "Konrad Dybcio" Cc: olteanv@gmail.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org, neil.armstrong@linaro.org, vkoul@kernel.org In-Reply-To: <20260518-topic-usb4phy-v1-4-71d827c49dca@oss.qualcomm.com> References: <20260518-topic-usb4phy-v1-4-71d827c49dca@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 18 May 2026 11:49:29 +0000 Message-Id: <20260518114931.B7A0DC2BCB7@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 4 potential issue(= s) to consider: - [Low] Incorrect `TX_` prefix for RX UCDR fastlock registers. - [Low] Typo in register macro name: `LPFS` instead of `LFPS`. - [Low] Redundant `PCS_PCS` prefix in register macro name. - [Low] Missing `_N4_` infix in the `QSERDES_V6_TX_LDO_TIMER_CTRL` macro. -- commit 13a3731f3b7c12c298d2f498011a7ef852fd4a42 Author: Konrad Dybcio phy: qualcomm: qmp-combo: Add USB4/TBT3 configuration data for Hamoa This commit adds the offsets and configuration tables to support USB4 and Thunderbolt 3 operation on the USB4-capable PHYs found on Hamoa chips. > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qual= comm/phy-qcom-qmp-combo.c > index 898f42de4a086..0916d9a4599ed 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c [ ... ] > @@ -1873,6 +1952,68 @@ static const struct qmp_phy_init_tbl x1e80100_usb4= 3dp_tx_tbl[] =3D { > [ ... ] > +static const struct qmp_phy_init_tbl x1e80100_usb4_rx_tbl[] =3D { > [ ... ] > + QMP_PHY_INIT_CFG(QSERDES_V6_N4_TX_UCDR_FASTLOCK_COUNTER_LOW_RATE2, 0x30= ), > + QMP_PHY_INIT_CFG(QSERDES_V6_N4_TX_UCDR_FASTLOCK_COUNTER_HIGH_RATE2, 0x1= 4), > + QMP_PHY_INIT_CFG(QSERDES_V6_N4_TX_UCDR_FASTLOCK_COUNTER_LOW_RATE3, 0xff= ), > + QMP_PHY_INIT_CFG(QSERDES_V6_N4_TX_UCDR_FASTLOCK_COUNTER_HIGH_RATE3, 0x3= f), This isn't a bug, but should these use the RX_ prefix instead of TX_?=20 These registers appear to map to the RX block address space and are used here to configure the RX hardware. [ ... ] > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcs-usb-v6.h b/drivers/phy= /qualcomm/phy-qcom-qmp-pcs-usb-v6.h > index df670143feb1e..30fdb437146c4 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcs-usb-v6.h > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcs-usb-v6.h > @@ -14,4 +14,19 @@ > #define QPHY_V6_PCS_USB3_RCVR_DTCT_DLY_U3_L 0x40 > #define QPHY_V6_PCS_USB3_RCVR_DTCT_DLY_U3_H 0x44 > =20 > +#define QPHY_V6_PCS_USB4_POWER_STATE_CONFIG3 0x98 > [ ... ] > +#define QPHY_V6_PCS_USB4_PCS_PCS_TX_RX_CONFIG1 0x1a8 This isn't a bug, but is there a duplicate PCS_ prefix in this macro name? > +#define QPHY_V6_PCS_USB4_EQ_CONFIG1 0x1b8 > [ ... ] > +#define QPHY_V6_PCS_USB4_LPFS_TX_ECSTART 0x220 This isn't a bug, but is this a typo for LFPS (Low Frequency Periodic Signaling)? [ ... ] > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-txrx-v6_n4.h b/dri= vers/phy/qualcomm/phy-qcom-qmp-qserdes-txrx-v6_n4.h > index d37cc0d4fd365..e72ae2cb460ac 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-txrx-v6_n4.h > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-txrx-v6_n4.h > @@ -23,27 +23,63 @@ > [ ... ] > #define QSERDES_V6_N4_TX_VMODE_CTRL1 0xb0 > +#define QSERDES_V6_TX_LDO_TIMER_CTRL 0x120 This isn't a bug, but should this macro include the _N4_ infix for consistency with the rest of the V6 N4 block definitions? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260518-topic-usb4= phy-v1-0-71d827c49dca@oss.qualcomm.com?part=3D4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94956CD4F3C for ; Mon, 18 May 2026 11:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nflLFb38sB3+o0cQJpMx26xrLJVZkBx6ufU2IrUX7wo=; b=LCxrL6JsRfMfR6 6Hr/R0XbTueLZsklDzyYzWtHsIn8GXHyea1qhyWd4P+Bcpq82DgzidK5SG64DU1lrzTRopYn5BX4Q /xtjpOkrGmonz7N49LMTb+nQxpmiSIOniSlL4U4XBFNk1US7p+0EPN6dF3ON3RGoy96Tp/hVcob/U +1tU/hvk/21UcRfr1BnyccbZmNG8z9Rz2mgnVEiloWhh0nAc4pFMtbmBlGR4nllrNwLbVMdll3YzC WpCc+7griL0Q12/blxZVichFXR8f0DGqE3wqnO+nCbe0Jzp0nzO1Fidamo5BgvRCjNcqYrIk2w4bc lgg4TBd377s4wVfx/7lA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wOwTY-0000000FV18-0dHw; Mon, 18 May 2026 11:49:36 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wOwTW-0000000FV0Q-0gPu for linux-phy@lists.infradead.org; Mon, 18 May 2026 11:49:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 5ECF760141; Mon, 18 May 2026 11:49:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7A0DC2BCB7; Mon, 18 May 2026 11:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779104972; bh=cNlP5bfLoARIVy4MMsIn8cjA7BGxZtEfDS9gueb1MFQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=Rs/hRu1qd3MCaspgLiBSjcA/qG4kUU2J/m7lnjr/SRbCzFfdSvBd6BenDY4aMH7La xGlD6dkffEZMUqvRRWJNqPHqeRTe+5XfuHcXTAKgCL1DY6kMtqIGAQa2pNmKCjdbD/ LJWIWXxTk0nhYLhSBETkEys+9ozsnI1M6hDSEnimIiVw1PB3v1uHk59BVbf/0zCC7M WRKd1wFDoeThIH1lExSgs7ss/snbopBtetIfz3PesUsW2DuhEKJHVim4QwZRb7CtDG lnn8gNZQrpl5eolIFOmj3lDPfUm/kscuHs6PupRDwfFFIqh2fzkQ3bNPuP7bF0ZvD8 JNw5THfcfublQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH 4/5] phy: qualcomm: qmp-combo: Add USB4/TBT3 configuration data for Hamoa To: "Konrad Dybcio" Cc: olteanv@gmail.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org, neil.armstrong@linaro.org, vkoul@kernel.org In-Reply-To: <20260518-topic-usb4phy-v1-4-71d827c49dca@oss.qualcomm.com> References: <20260518-topic-usb4phy-v1-4-71d827c49dca@oss.qualcomm.com> Date: Mon, 18 May 2026 11:49:29 +0000 Message-Id: <20260518114931.B7A0DC2BCB7@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NCBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gSW5jb3JyZWN0IGBUWF9g IHByZWZpeCBmb3IgUlggVUNEUiBmYXN0bG9jayByZWdpc3RlcnMuCi0gW0xvd10gVHlwbyBpbiBy ZWdpc3RlciBtYWNybyBuYW1lOiBgTFBGU2AgaW5zdGVhZCBvZiBgTEZQU2AuCi0gW0xvd10gUmVk dW5kYW50IGBQQ1NfUENTYCBwcmVmaXggaW4gcmVnaXN0ZXIgbWFjcm8gbmFtZS4KLSBbTG93XSBN aXNzaW5nIGBfTjRfYCBpbmZpeCBpbiB0aGUgYFFTRVJERVNfVjZfVFhfTERPX1RJTUVSX0NUUkxg IG1hY3JvLgotLQoKY29tbWl0IDEzYTM3MzFmM2I3YzEyYzI5OGQyZjQ5ODAxMWE3ZWY4NTJmZDRh NDIKQXV0aG9yOiBLb25yYWQgRHliY2lvIDxrb25yYWQuZHliY2lvQG9zcy5xdWFsY29tbS5jb20+ CgpwaHk6IHF1YWxjb21tOiBxbXAtY29tYm86IEFkZCBVU0I0L1RCVDMgY29uZmlndXJhdGlvbiBk YXRhIGZvciBIYW1vYQoKVGhpcyBjb21taXQgYWRkcyB0aGUgb2Zmc2V0cyBhbmQgY29uZmlndXJh dGlvbiB0YWJsZXMgdG8gc3VwcG9ydCBVU0I0CmFuZCBUaHVuZGVyYm9sdCAzIG9wZXJhdGlvbiBv biB0aGUgVVNCNC1jYXBhYmxlIFBIWXMgZm91bmQgb24gSGFtb2EgY2hpcHMuCgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL3BoeS9xdWFsY29tbS9waHktcWNvbS1xbXAtY29tYm8uYyBiL2RyaXZlcnMv cGh5L3F1YWxjb21tL3BoeS1xY29tLXFtcC1jb21iby5jCj4gaW5kZXggODk4ZjQyZGU0YTA4Ni4u MDkxNmQ5YTQ1OTllZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BoeS9xdWFsY29tbS9waHktcWNv bS1xbXAtY29tYm8uYwo+ICsrKyBiL2RyaXZlcnMvcGh5L3F1YWxjb21tL3BoeS1xY29tLXFtcC1j b21iby5jCgpbIC4uLiBdCgo+IEBAIC0xODczLDYgKzE5NTIsNjggQEAgc3RhdGljIGNvbnN0IHN0 cnVjdCBxbXBfcGh5X2luaXRfdGJsIHgxZTgwMTAwX3VzYjQzZHBfdHhfdGJsW10gPSB7Cj4gWyAu Li4gXQo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHFtcF9waHlfaW5pdF90YmwgeDFlODAxMDBfdXNi NF9yeF90YmxbXSA9IHsKPiBbIC4uLiBdCj4gKwlRTVBfUEhZX0lOSVRfQ0ZHKFFTRVJERVNfVjZf TjRfVFhfVUNEUl9GQVNUTE9DS19DT1VOVEVSX0xPV19SQVRFMiwgMHgzMCksCj4gKwlRTVBfUEhZ X0lOSVRfQ0ZHKFFTRVJERVNfVjZfTjRfVFhfVUNEUl9GQVNUTE9DS19DT1VOVEVSX0hJR0hfUkFU RTIsIDB4MTQpLAo+ICsJUU1QX1BIWV9JTklUX0NGRyhRU0VSREVTX1Y2X040X1RYX1VDRFJfRkFT VExPQ0tfQ09VTlRFUl9MT1dfUkFURTMsIDB4ZmYpLAo+ICsJUU1QX1BIWV9JTklUX0NGRyhRU0VS REVTX1Y2X040X1RYX1VDRFJfRkFTVExPQ0tfQ09VTlRFUl9ISUdIX1JBVEUzLCAweDNmKSwKClRo aXMgaXNuJ3QgYSBidWcsIGJ1dCBzaG91bGQgdGhlc2UgdXNlIHRoZSBSWF8gcHJlZml4IGluc3Rl YWQgb2YgVFhfPyAKVGhlc2UgcmVnaXN0ZXJzIGFwcGVhciB0byBtYXAgdG8gdGhlIFJYIGJsb2Nr IGFkZHJlc3Mgc3BhY2UgYW5kIGFyZSB1c2VkCmhlcmUgdG8gY29uZmlndXJlIHRoZSBSWCBoYXJk d2FyZS4KClsgLi4uIF0KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L3F1YWxjb21tL3BoeS1x Y29tLXFtcC1wY3MtdXNiLXY2LmggYi9kcml2ZXJzL3BoeS9xdWFsY29tbS9waHktcWNvbS1xbXAt cGNzLXVzYi12Ni5oCj4gaW5kZXggZGY2NzAxNDNmZWIxZS4uMzBmZGI0MzcxNDZjNCAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL3BoeS9xdWFsY29tbS9waHktcWNvbS1xbXAtcGNzLXVzYi12Ni5oCj4g KysrIGIvZHJpdmVycy9waHkvcXVhbGNvbW0vcGh5LXFjb20tcW1wLXBjcy11c2ItdjYuaAo+IEBA IC0xNCw0ICsxNCwxOSBAQAo+ICAjZGVmaW5lIFFQSFlfVjZfUENTX1VTQjNfUkNWUl9EVENUX0RM WV9VM19MCQkweDQwCj4gICNkZWZpbmUgUVBIWV9WNl9QQ1NfVVNCM19SQ1ZSX0RUQ1RfRExZX1Uz X0gJCTB4NDQKPiAgCj4gKyNkZWZpbmUgUVBIWV9WNl9QQ1NfVVNCNF9QT1dFUl9TVEFURV9DT05G SUczCQkweDk4Cj4gWyAuLi4gXQo+ICsjZGVmaW5lIFFQSFlfVjZfUENTX1VTQjRfUENTX1BDU19U WF9SWF9DT05GSUcxCQkweDFhOAoKVGhpcyBpc24ndCBhIGJ1ZywgYnV0IGlzIHRoZXJlIGEgZHVw bGljYXRlIFBDU18gcHJlZml4IGluIHRoaXMgbWFjcm8gbmFtZT8KCj4gKyNkZWZpbmUgUVBIWV9W Nl9QQ1NfVVNCNF9FUV9DT05GSUcxCQkJMHgxYjgKPiBbIC4uLiBdCj4gKyNkZWZpbmUgUVBIWV9W Nl9QQ1NfVVNCNF9MUEZTX1RYX0VDU1RBUlQJCTB4MjIwCgpUaGlzIGlzbid0IGEgYnVnLCBidXQg aXMgdGhpcyBhIHR5cG8gZm9yIExGUFMgKExvdyBGcmVxdWVuY3kgUGVyaW9kaWMKU2lnbmFsaW5n KT8KClsgLi4uIF0KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L3F1YWxjb21tL3BoeS1xY29t LXFtcC1xc2VyZGVzLXR4cngtdjZfbjQuaCBiL2RyaXZlcnMvcGh5L3F1YWxjb21tL3BoeS1xY29t LXFtcC1xc2VyZGVzLXR4cngtdjZfbjQuaAo+IGluZGV4IGQzN2NjMGQ0ZmQzNjUuLmU3MmFlMmNi NDYwYWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9waHkvcXVhbGNvbW0vcGh5LXFjb20tcW1wLXFz ZXJkZXMtdHhyeC12Nl9uNC5oCj4gKysrIGIvZHJpdmVycy9waHkvcXVhbGNvbW0vcGh5LXFjb20t cW1wLXFzZXJkZXMtdHhyeC12Nl9uNC5oCj4gQEAgLTIzLDI3ICsyMyw2MyBAQAo+IFsgLi4uIF0K PiAgI2RlZmluZSBRU0VSREVTX1Y2X040X1RYX1ZNT0RFX0NUUkwxCQkJMHhiMAo+ICsjZGVmaW5l IFFTRVJERVNfVjZfVFhfTERPX1RJTUVSX0NUUkwJCQkweDEyMAoKVGhpcyBpc24ndCBhIGJ1Zywg YnV0IHNob3VsZCB0aGlzIG1hY3JvIGluY2x1ZGUgdGhlIF9ONF8gaW5maXggZm9yCmNvbnNpc3Rl bmN5IHdpdGggdGhlIHJlc3Qgb2YgdGhlIFY2IE40IGJsb2NrIGRlZmluaXRpb25zPwoKLS0gClNh c2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDUx OC10b3BpYy11c2I0cGh5LXYxLTAtNzFkODI3YzQ5ZGNhQG9zcy5xdWFsY29tbS5jb20/cGFydD00 CgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK