From: Klaus Jensen <its@irrelevant.dk>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Klaus Jensen" <k.jensen@samsung.com>,
"Keith Busch" <kbusch@kernel.org>,
"Klaus Jensen" <its@irrelevant.dk>,
"Jesper Devantier" <foss@defmacro.it>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
qemu-block@nongnu.org
Subject: [PULL 1/5] include/block: define constants for NVME string fields
Date: Mon, 18 May 2026 14:07:44 +0200 [thread overview]
Message-ID: <20260518120748.14831-2-its@irrelevant.dk> (raw)
In-Reply-To: <20260518120748.14831-1-its@irrelevant.dk>
From: Daniel P. Berrangé <berrange@redhat.com>
The version, model and serial fields accept fixed length strings.
Add constants to enable user supplied strings to be validated.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
include/block/nvme.h | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/include/block/nvme.h b/include/block/nvme.h
index 9d7159ed7a7a..e4e7be51205e 100644
--- a/include/block/nvme.h
+++ b/include/block/nvme.h
@@ -1134,12 +1134,16 @@ enum NvmeIdCns {
NVME_ID_CNS_CS_IND_NS_ALLOCATED = 0x1f,
};
+#define NVME_ID_CTRL_SN_MAX_LEN 20
+#define NVME_ID_CTRL_MN_MAX_LEN 40
+#define NVME_ID_CTRL_FR_MAX_LEN 8
+
typedef struct QEMU_PACKED NvmeIdCtrl {
uint16_t vid;
uint16_t ssvid;
- uint8_t sn[20];
- uint8_t mn[40];
- uint8_t fr[8];
+ uint8_t sn[NVME_ID_CTRL_SN_MAX_LEN];
+ uint8_t mn[NVME_ID_CTRL_MN_MAX_LEN];
+ uint8_t fr[NVME_ID_CTRL_FR_MAX_LEN];
uint8_t rab;
uint8_t ieee[3];
uint8_t cmic;
--
2.53.0
next prev parent reply other threads:[~2026-05-18 12:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 12:07 [PULL 0/5] hw/nvme queue Klaus Jensen
2026-05-18 12:07 ` Klaus Jensen [this message]
2026-05-18 12:07 ` [PULL 2/5] hw/nvme: report error for oversized 'serial' parameter Klaus Jensen
2026-05-18 12:07 ` [PULL 3/5] hw/nvme: add user controlled 'model' property Klaus Jensen
2026-05-18 12:07 ` [PULL 4/5] hw/nvme: add user controlled 'firmware-version' property Klaus Jensen
2026-05-18 12:07 ` [PULL 5/5] hw/nvme: fix admin cq msix setup Klaus Jensen
2026-05-19 12:39 ` [PULL 0/5] hw/nvme queue Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518120748.14831-2-its@irrelevant.dk \
--to=its@irrelevant.dk \
--cc=berrange@redhat.com \
--cc=fam@euphon.net \
--cc=foss@defmacro.it \
--cc=hreitz@redhat.com \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.