All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Christian Marangi" <ansuelsmth@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: nvmem: airoha: add SMC eFuses schema
Date: Mon, 18 May 2026 14:31:55 +0000	[thread overview]
Message-ID: <20260518143156.4F58EC2BCB8@smtp.kernel.org> (raw)
In-Reply-To: <20260518142042.8331-2-ansuelsmth@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The `compatible` property enum omits the AN7583 SoC despite the commit message claiming support.
- [Medium] The `#address-cells` and `#size-cells` properties are missing from the `required` list.
--

commit e333b70b463993a4fe3c97641d9aaa8019a4117c
Author: Christian Marangi <ansuelsmth@gmail.com>

dt-bindings: nvmem: airoha: add SMC eFuses schema

Add Airoha SMC eFuses schema to document new Airoha SoC AN7581/AN7583
way of accessing the 2 eFuse bank via the SMC command.

> diff --git a/Documentation/devicetree/bindings/nvmem/airoha,smc-efuses.yaml b/Documentation/devicetree/bindings/nvmem/airoha,smc-efuses.yaml
> new file mode 100644
> index 0000000000000..e21ce07c4f411
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/airoha,smc-efuses.yaml

[ ... ]

> +properties:
> +  compatible:
> +    enum:
> +      - airoha,an7581-efuses

The commit message mentions this schema supports both the AN7581 and AN7583
SoCs. Should airoha,an7583-efuses be included in this enum, or is there a
reason only the AN7581 compatible string is listed?

> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0

[ ... ]

> +    required:
> +      - reg
> +
> +    unevaluatedProperties: false
> +
> +required:
> +  - compatible

Since the schema defines child nodes (efuse-bank@[0-1]) that use the reg
property, should #address-cells and #size-cells be added to this required
list to ensure the device tree is structurally valid?

> +
> +additionalProperties: false

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260518142042.8331-1-ansuelsmth@gmail.com?part=1

  reply	other threads:[~2026-05-18 14:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 14:20 [PATCH v3 0/2] nvmem: airoha: Add support for SMC eFUSE Christian Marangi
2026-05-18 14:20 ` [PATCH v3 1/2] dt-bindings: nvmem: airoha: add SMC eFuses schema Christian Marangi
2026-05-18 14:31   ` sashiko-bot [this message]
2026-05-18 14:20 ` [PATCH v3 2/2] nvmem: airoha: Add support for SMC eFUSE Christian Marangi
2026-05-18 14:53   ` sashiko-bot
2026-05-19 14:27   ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260518143156.4F58EC2BCB8@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=ansuelsmth@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.