From: Thorsten Blum <thorsten.blum@linux.dev>
To: Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Thorsten Blum <thorsten.blum@linux.dev>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] sh: dma-sysfs: use strscpy in dma_store_dev_id
Date: Mon, 18 May 2026 19:10:42 +0200 [thread overview]
Message-ID: <20260518171040.81917-6-thorsten.blum@linux.dev> (raw)
In-Reply-To: <20260518171040.81917-5-thorsten.blum@linux.dev>
strcpy() has been deprecated¹ because it performs no bounds checking on
the destination buffer, which can lead to buffer overflows. Replace it
with the safer strscpy().
¹ https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/sh/drivers/dma/dma-sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sh/drivers/dma/dma-sysfs.c b/arch/sh/drivers/dma/dma-sysfs.c
index d4e16cfc7a12..d1d6b9bb0d7e 100644
--- a/arch/sh/drivers/dma/dma-sysfs.c
+++ b/arch/sh/drivers/dma/dma-sysfs.c
@@ -74,7 +74,7 @@ static ssize_t dma_store_dev_id(struct device *dev,
const char *buf, size_t count)
{
struct dma_channel *channel = to_dma_channel(dev);
- strcpy(channel->dev_id, buf);
+ strscpy(channel->dev_id, buf);
return count;
}
next prev parent reply other threads:[~2026-05-18 17:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 17:10 [PATCH 1/3] sh: dma-sysfs: use sysfs_emit{_at} in show functions Thorsten Blum
2026-05-18 17:10 ` Thorsten Blum [this message]
2026-05-18 17:10 ` [PATCH 3/3] sh: dma: drop redundant size argument from strscpy in request_dma Thorsten Blum
-- strict thread matches above, loose matches on Subject: below --
2026-04-20 15:09 [PATCH 1/3] sh: dma-sysfs: use sysfs_emit{_at} in show functions Thorsten Blum
2026-04-20 15:09 ` [PATCH 2/3] sh: dma-sysfs: use strscpy in dma_store_dev_id Thorsten Blum
2026-04-21 7:04 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518171040.81917-6-thorsten.blum@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=dalias@libc.org \
--cc=geert+renesas@glider.be \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.