From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,joonwonkang@google.com,akpm@linux-foundation.org
Subject: [to-be-updated] percpu-do-not-trust-hint-starts-when-they-are-not-set.patch removed from -mm tree
Date: Mon, 18 May 2026 10:54:18 -0700 [thread overview]
Message-ID: <20260518175419.18977C2BCB7@smtp.kernel.org> (raw)
The quilt patch titled
Subject: percpu: do not trust hint starts when they are not set
has been removed from the -mm tree. Its filename was
percpu-do-not-trust-hint-starts-when-they-are-not-set.patch
This patch was dropped because an updated version will be issued
------------------------------------------------------
From: Joonwon Kang <joonwonkang@google.com>
Subject: percpu: do not trust hint starts when they are not set
Date: Sun, 10 May 2026 07:21:47 +0000
contig_hint_start can be trusted outside the hint update function since it
will be updated everytime contig_hint is broken. On the other hand,
scan_hint_start might still be invalid anywhere in the code due to the
broken scan_hint not being updated promptly. If those starts are trusted
when they are not set, it could lead to false invalidation or update of
the hints.
Link: https://lore.kernel.org/20260510072149.1279887-2-joonwonkang@google.com
Signed-off-by: Joonwon Kang <joonwonkang@google.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Dennis Zhou <dennis@kernel.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: <dodam@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/percpu.c | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)
--- a/mm/percpu.c~percpu-do-not-trust-hint-starts-when-they-are-not-set
+++ a/mm/percpu.c
@@ -640,12 +640,13 @@ static void pcpu_block_update(struct pcp
if (contig > block->contig_hint) {
/* promote the old contig_hint to be the new scan_hint */
- if (start > block->contig_hint_start) {
+ if (block->contig_hint && start > block->contig_hint_start) {
if (block->contig_hint > block->scan_hint) {
block->scan_hint_start =
block->contig_hint_start;
block->scan_hint = block->contig_hint;
- } else if (start < block->scan_hint_start) {
+ } else if (block->scan_hint &&
+ start < block->scan_hint_start) {
/*
* The old contig_hint == scan_hint. But, the
* new contig is larger so hold the invariant
@@ -664,10 +665,12 @@ static void pcpu_block_update(struct pcp
__ffs(start) > __ffs(block->contig_hint_start))) {
/* start has a better alignment so use it */
block->contig_hint_start = start;
- if (start < block->scan_hint_start &&
+ if (block->scan_hint &&
+ start < block->scan_hint_start &&
block->contig_hint > block->scan_hint)
block->scan_hint = 0;
- } else if (start > block->scan_hint_start ||
+ } else if ((block->scan_hint &&
+ start > block->scan_hint_start) ||
block->contig_hint > block->scan_hint) {
/*
* Knowing contig == contig_hint, update the scan_hint
@@ -845,7 +848,8 @@ static void pcpu_block_update_hint_alloc
PCPU_BITMAP_BLOCK_BITS,
s_off + bits);
- if (pcpu_region_overlap(s_block->scan_hint_start,
+ if (s_block->scan_hint &&
+ pcpu_region_overlap(s_block->scan_hint_start,
s_block->scan_hint_start + s_block->scan_hint,
s_off,
s_off + bits))
@@ -889,7 +893,8 @@ static void pcpu_block_update_hint_alloc
/* reset the block */
e_block++;
} else {
- if (e_off > e_block->scan_hint_start)
+ if (e_block->scan_hint &&
+ e_off > e_block->scan_hint_start)
e_block->scan_hint = 0;
e_block->left_free = 0;
@@ -922,7 +927,8 @@ static void pcpu_block_update_hint_alloc
if (nr_empty_pages)
pcpu_update_empty_pages(chunk, -nr_empty_pages);
- if (pcpu_region_overlap(chunk_md->scan_hint_start,
+ if (chunk_md->scan_hint &&
+ pcpu_region_overlap(chunk_md->scan_hint_start,
chunk_md->scan_hint_start +
chunk_md->scan_hint,
bit_off,
_
Patches currently in -mm which might be from joonwonkang@google.com are
a.patch
percpu-introduce-struct-pcpu_region.patch
percpu-fix-hint-invariant-breakage.patch
next reply other threads:[~2026-05-18 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 17:54 Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-29 4:51 [to-be-updated] percpu-do-not-trust-hint-starts-when-they-are-not-set.patch removed from -mm tree Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518175419.18977C2BCB7@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=joonwonkang@google.com \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.