From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E2BA38238F for ; Mon, 18 May 2026 16:54:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779123291; cv=none; b=tuWxKaR4VoUG0kUnj227gbeFJ6im3mOmdEpAwuwNVMhbxgb58TReboTfCvYG7d/181dHocOMCLZEFszPVXcdw9jO1eTEEVztXB/A+pn+NBJHw+Mub7gECOOp3HJUKFAC98gXQWf9SFipsdmPBlG+t4cvsoGKIsMpUnOKAsoaYLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779123291; c=relaxed/simple; bh=9tOP69edC+8mg6obhJG3L8gE/dfZBiv1krm8rRih1/Q=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=t0j+xTn9+hfnsawMw2UQSbKeyJFtAS5UTfiUFaM2CWCkJj1mTp2GWMCJ5IC3tQhchYNqlBBR1Hybk29rsqVJuqymfLMBwvvyQOu90kLp+BLbHoyvIKKjcS70V1aGMivMIdhGoVOXcOcPW2LoCOtANW7J9Z2mqHEXj2ONq+4kutU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jcLn00Vc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jcLn00Vc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59FE9C2BCB7; Mon, 18 May 2026 16:54:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779123290; bh=9tOP69edC+8mg6obhJG3L8gE/dfZBiv1krm8rRih1/Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jcLn00VcpjyiSJrYI+Xcp/Q5KrecFNpxAON7D8gA8q8CqXKlhUPDLAyY35J0QFLCX iKWR9b4MA6J2Ft+pomiEQdsvQJQ1wU58v/hUPi+GjJlcz0KPFgotgUYi8RXOR527du cc5GAcbn27IXvyG9i31u72UAbKsuyxlSRii3Ja8NZc4OVa+crR5QDDHun9jdCXQIIO OEHyVVHTxK3MLtt8KxltkJ0Zg5qecD3spkID0TT20iTrMRRC81A6be9ft3x5zMhLuY bz96XdaxunPGfJzVFwWyP5PRPfb/nX+Hj3vCXm/JpP1yblVCnLWe2m586pCjZpRRkR Vp45mRulic4/A== Date: Mon, 18 May 2026 17:54:29 +0100 From: Jonathan Cameron To: Shivank Garg Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Baolin Wang , Lance Yang Subject: Re: [PATCH 1/7] mm/migrate: rename PAGE_ migration flags to FOLIO_ Message-ID: <20260518175429.1b28e8c1@jic23-huawei> In-Reply-To: <20260428155043.39251-4-shivankg@amd.com> References: <20260428155043.39251-2-shivankg@amd.com> <20260428155043.39251-4-shivankg@amd.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 28 Apr 2026 15:50:39 +0000 Shivank Garg wrote: > These flags only track folio-specific state during migration and are > not used for movable_ops pages. Rename the enum values and the > old_page_state variable to match. > > No functional change. > > Suggested-by: David Hildenbrand > Acked-by: David Hildenbrand (Arm) > Reviewed-by: Zi Yan > Reviewed-by: Baolin Wang > Reviewed-by: Lance Yang > Signed-off-by: Shivank Garg Hi. A few trivial things inline. Thanks, > --- > mm/migrate.c | 48 +++++++++++++++++++++++------------------------- > 1 file changed, 23 insertions(+), 25 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > static void __migrate_folio_record(struct folio *dst, > - int old_page_state, > - struct anon_vma *anon_vma) > + int old_folio_state, struct anon_vma *anon_vma) Trivial but why the formatting change? This is all well under 80 chars and it makes the diff a tiny bit worse than it would otherwise be. > { > - dst->private = (void *)anon_vma + old_page_state; > + dst->private = (void *)anon_vma + old_folio_state; > } > > static void __migrate_folio_extract(struct folio *dst, > - int *old_page_state, > - struct anon_vma **anon_vmap) > + int *old_folio_state, struct anon_vma **anon_vmap) Same as above - avoid the reformat. > { > unsigned long private = (unsigned long)dst->private; >