All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Louis Sautier" <sautier.louis@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 2/2] scsi: mpt3sas: add hwmon support
Date: Mon, 18 May 2026 19:37:57 +0000	[thread overview]
Message-ID: <20260518193758.889DCC2BCB7@smtp.kernel.org> (raw)
In-Reply-To: <20260518184109.770185-3-sautier.louis@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The Kconfig help text references a non-existent documentation file.
--

commit 8d7ed075db4ca1d1d6c8f7e90a2625cc47892773
Author: Louis Sautier <sautier.louis@gmail.com>

scsi: mpt3sas: add hwmon support

This commit exposes the IOC and board temperature sensors of LSI /
Broadcom SAS HBAs through the hardware monitoring subsystem, using
readings from MPI IO Unit Page 7.

> diff --git a/drivers/scsi/mpt3sas/Kconfig b/drivers/scsi/mpt3sas/Kconfig
> index c299f7e078fb9..638acd2c66236 100644
> --- a/drivers/scsi/mpt3sas/Kconfig
> +++ b/drivers/scsi/mpt3sas/Kconfig
> @@ -73,6 +73,15 @@ config SCSI_MPT3SAS_MAX_SGE
>  	can be 256. However, it may decreased down to 16.  Decreasing this
>  	parameter will reduce memory requirements on a per controller instance.
>  
> +config SCSI_MPT3SAS_HWMON
> +	bool "LSI MPT Fusion SAS hwmon support"
> +	depends on SCSI_MPT3SAS && HWMON
> +	depends on !(SCSI_MPT3SAS=y && HWMON=m)
> +	help
> +	Say Y here to expose the IOC and board temperature sensors of
> +	LSI / Broadcom SAS HBAs (such as the 9300, 9400, and 9500 series)
> +	through hwmon. See Documentation/hwmon/mpt3sas.rst for details.

This isn't a bug, but the help text references a documentation file that
doesn't seem to be included in this patch. Is Documentation/hwmon/mpt3sas.rst
missing from this commit, or was this added in a separate patch series?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260518184109.770185-1-sautier.louis@gmail.com?part=2

  reply	other threads:[~2026-05-18 19:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 18:41 [PATCH v2 0/2] scsi: mpt3sas: add hwmon support Louis Sautier
2026-05-18 18:41 ` [PATCH v2 1/2] scsi: mpt3sas: add IO Unit Page 7 config accessor Louis Sautier
2026-05-18 18:41 ` [PATCH v2 2/2] scsi: mpt3sas: add hwmon support Louis Sautier
2026-05-18 19:37   ` sashiko-bot [this message]
2026-05-18 19:46     ` Louis Sautier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260518193758.889DCC2BCB7@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sautier.louis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.