All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Xuewen Wang <wangxuewen@kylinos.cn>
Cc: SeongJae Park <sj@kernel.org>,
	akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] tools/mm/slabinfo: remove dead assignment in get_obj_and_str()
Date: Mon, 18 May 2026 17:32:56 -0700	[thread overview]
Message-ID: <20260519003257.99650-1-sj@kernel.org> (raw)
In-Reply-To: <20260518062159.80664-3-wangxuewen@kylinos.cn>

On Mon, 18 May 2026 14:21:58 +0800 Xuewen Wang <wangxuewen@kylinos.cn> wrote:

> The assignment `x = NULL` sets the local parameter variable instead of
> `*x`, which is a no-op since `*x` was already set to NULL on the line
> above. Remove the dead assignment.
> 
> Signed-off-by: Xuewen Wang <wangxuewen@kylinos.cn>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]


  reply	other threads:[~2026-05-19  0:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18  6:21 [PATCH v2 0/3] Cleanup and fix tools/mm/slabinfo utility Xuewen Wang
2026-05-18  6:21 ` [PATCH v2 1/3] tools/mm/slabinfo: Fix trace disable logic inversion Xuewen Wang
2026-05-18  6:21 ` [PATCH v2 2/3] tools/mm/slabinfo: remove dead assignment in get_obj_and_str() Xuewen Wang
2026-05-19  0:32   ` SeongJae Park [this message]
2026-05-18  6:21 ` [PATCH v2 3/3] tools/mm/slabinfo: remove redundant slab->partial assignment Xuewen Wang
2026-05-25  8:38 ` [PATCH v2 0/3] Cleanup and fix tools/mm/slabinfo utility Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260519003257.99650-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=wangxuewen@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.