All of lore.kernel.org
 help / color / mirror / Atom feed
From: Byungchul Park <byungchul@sk.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Lorenzo Stoakes <ljs@kernel.org>,
	kernel_team@skhynix.com, ast@kernel.org, daniel@iogearbox.net,
	davem@davemloft.net, kuba@kernel.org, hawk@kernel.org,
	john.fastabend@gmail.com, sdf@fomichev.me, saeedm@nvidia.com,
	leon@kernel.org, tariqt@nvidia.com, mbloch@nvidia.com,
	andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com,
	david@kernel.org, liam@infradead.org, vbabka@kernel.org,
	rppt@kernel.org, surenb@google.com, mhocko@suse.com,
	horms@kernel.org, jackmanb@google.com, hannes@cmpxchg.org,
	ziy@nvidia.com, ilias.apalodimas@linaro.org, kas@kernel.org,
	willy@infradead.org, baolin.wang@linux.alibaba.com,
	asml.silence@gmail.com, toke@redhat.com, netdev@vger.kernel.org,
	bpf@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] Revert "mm: introduce a new page type for page pool in page type"
Date: Tue, 19 May 2026 09:34:50 +0900	[thread overview]
Message-ID: <20260519003450.GA46041@system.software.com> (raw)
In-Reply-To: <20260518173119.f3348ec4cc66b793fed4cccf@linux-foundation.org>

On Mon, May 18, 2026 at 05:31:19PM -0700, Andrew Morton wrote:
> On Mon, 18 May 2026 12:00:11 +0100 Lorenzo Stoakes <ljs@kernel.org> wrote:
> 
> > Maybe worth putting [PATCH mm-hotfixes] just to make it clear this should be an
> > urgent hotfix?
> >
> > On Fri, May 15, 2026 at 12:47:01PM +0900, Byungchul Park wrote:
> > > This reverts commit db359fccf212e7fa3136e6edbed6228475646fd7.
> >
> > Maybe 'this reverts commit db359fccf212 ("...") and partially reverts commit
> > 735a309b4bfb9e ("...") <details>'?
> >
> > >
> > > Netpp page_type'ed pages might be used in mapping so as to use
> > > @_mapcount.  However, since @page_type and @_mapcount are union'ed in
> > > struct page, these two can't be used at the same time.  Revert the
> > > commit introducing page_type for Netpp for now.
> >
> > Yikes!
> >
> > >
> > > The patch will be retried once @page_type and @_mapcount get allowed to
> > > be used at the same time.
> > >
> > > The revert also includes removal of @page_type initialization part
> > > introduced by commit 735a309b4bfb9e ("net: add net_iov_init() and use it
> > > to initialize ->page_type"), which will be restored on the retry.
> >
> > As above maybe mentioning at top of commit msg, as right now this reads as a
> > pure revert of db359fccf212.
> 
> I did

Oh great!  Thanks.

	Byungchul

> : This reverts commit db359fccf212 ("mm: introduce a new page type for page
> : pool in page type") and a part of 735a309b4bfb9e ("net: add net_iov_init()
> : and use it > to initialize ->page_type").
> 
> > >
> > > Reported-by: Dragos Tatulea <dtatulea@nvidia.com>
> > > Closes: https://lore.kernel.org/all/982b9bc1-0a0a-4fc5-8e3a-3672db2b29a1@nvidia.com
> >
> > Fixes tag?
> 
> I assume db359fccf212 ("mm: introduce a new page type for page pool in
> page type") is close enough.  Both that and 735a309b4bfb9e are new in
> 7.1-rcX.

  reply	other threads:[~2026-05-19  0:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15  3:47 [PATCH] Revert "mm: introduce a new page type for page pool in page type" Byungchul Park
2026-05-16  0:10 ` Jakub Kicinski
2026-05-18  8:20 ` David Hildenbrand (Arm)
2026-05-18  9:49 ` Harry Yoo (Oracle)
2026-05-18 11:00 ` Lorenzo Stoakes
2026-05-19  0:31   ` Andrew Morton
2026-05-19  0:34     ` Byungchul Park [this message]
2026-05-19  0:57   ` Byungchul Park
2026-05-22  7:45 ` Vlastimil Babka (SUSE)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260519003450.GA46041@system.software.com \
    --to=byungchul@sk.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=asml.silence@gmail.com \
    --cc=ast@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=david@kernel.org \
    --cc=edumazet@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jackmanb@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=kas@kernel.org \
    --cc=kernel_team@skhynix.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=mhocko@suse.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rppt@kernel.org \
    --cc=saeedm@nvidia.com \
    --cc=sdf@fomichev.me \
    --cc=surenb@google.com \
    --cc=tariqt@nvidia.com \
    --cc=toke@redhat.com \
    --cc=vbabka@kernel.org \
    --cc=willy@infradead.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.