From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Konstantin Ananyev <konstantin.ananyev@huawei.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Robin Jarry <rjarry@redhat.com>,
stable@dpdk.org
Subject: Re: [PATCH v3 1/3] spinlock: remove volatile qualifier
Date: Tue, 19 May 2026 06:32:00 -0700 [thread overview]
Message-ID: <20260519063200.66dabed6@phoenix.local> (raw)
In-Reply-To: <20260519103640.3986710-1-thomas@monjalon.net>
On Tue, 19 May 2026 12:34:14 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:
> When compiling with C++20 standard requirement (default in GCC 16),
> the increment and decrement of volatile variables are rejected:
>
> rte_spinlock.h:241:14: error:
> '++' expression of 'volatile'-qualified type is deprecated
> rte_spinlock.h:252:21: error:
> '--' expression of 'volatile'-qualified type is deprecated
> rte_spinlock.h:278:14: error:
> '++' expression of 'volatile'-qualified type is deprecated
>
> The count field of rte_spinlock_recursive_t
> does not need the volatile qualifier
> because it is only accessed by the thread holding the lock,
> which already provides the necessary memory ordering.
>
> The user field can be accessed outside of the lock,
> so it must handled as a C11 atomic variable.
> The name is also changed from user to owner.
> It will break if an application is accessing this field directly,
> which should never happen.
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed
Series-acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2026-05-19 13:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 8:37 [PATCH] spinlock: remove volatile qualifier Thomas Monjalon
2026-05-04 9:06 ` Thomas Monjalon
2026-05-04 9:12 ` [PATCH] spinlock: fix API comments Thomas Monjalon
2026-05-04 12:46 ` Thomas Monjalon
2026-05-18 13:57 ` [PATCH] spinlock: remove volatile qualifier Thomas Monjalon
2026-05-04 17:02 ` Stephen Hemminger
2026-05-05 7:01 ` Thomas Monjalon
2026-05-05 13:24 ` Stephen Hemminger
2026-05-18 15:07 ` [PATCH v2 1/2] " Thomas Monjalon
2026-05-18 15:07 ` [PATCH v2 2/2] spinlock: fix API comments Thomas Monjalon
2026-05-18 15:14 ` [PATCH v2 1/2] spinlock: remove volatile qualifier Robin Jarry
2026-05-18 15:25 ` Thomas Monjalon
2026-05-18 15:28 ` Bruce Richardson
2026-05-19 9:17 ` Robin Jarry
2026-05-19 10:35 ` Thomas Monjalon
2026-05-18 16:26 ` Stephen Hemminger
2026-05-18 16:28 ` Stephen Hemminger
2026-05-19 10:34 ` [PATCH v3 1/3] " Thomas Monjalon
2026-05-19 10:34 ` [PATCH v3 2/3] spinlock: add debug checks in recursive unlock Thomas Monjalon
2026-05-19 11:19 ` Thomas Monjalon
2026-05-19 11:47 ` Robin Jarry
2026-05-19 10:34 ` [PATCH v3 3/3] spinlock: fix API comments Thomas Monjalon
2026-05-19 11:03 ` [PATCH v3 1/3] spinlock: remove volatile qualifier Bruce Richardson
2026-05-19 13:32 ` Stephen Hemminger [this message]
2026-05-19 15:02 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519063200.66dabed6@phoenix.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=rjarry@redhat.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.