Re: [PATCH v5 07/19] drm/colorop: Create drm_atomic_helper_colorop_create_state()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `drm_atomic_helper_colorop_create_state` helper function lacks an `EXPORT_SYMBOL()` declaration and the `atomic_create_state` hook was not added to `struct drm_colorop_funcs`.
--

commit 96308971f93a9789ee23443eab7d504d21283abe
Author: Maxime Ripard <mripard@kernel.org>

drm/colorop: Create drm_atomic_helper_colorop_create_state()

Commit 47b5ac7daa46 ("drm/atomic: Add new atomic_create_state callback
to drm_private_obj") introduced a new pattern for allocating drm object
states. This commit creates a new hook that allocates and initializes a
pristine state without side effects for colorops.

> diff --git a/drivers/gpu/drm/drm_colorop.c b/drivers/gpu/drm/drm_colorop.c
> index 4c4d0a953e357..c0eecde8c1762 100644
> --- a/drivers/gpu/drm/drm_colorop.c
> +++ b/drivers/gpu/drm/drm_colorop.c
> @@ -523,6 +523,29 @@ static void __drm_colorop_state_init(struct drm_colorop_state *colorop_state,
>  	}
>  }
>  
> +/**
> + * drm_atomic_helper_colorop_create_state - Allocates and initializes colorop atomic state
> + * @colorop: drm colorop
> + *
> + * Initializes a pristine @drm_colorop_state.
> + *
> + * RETURNS:
> + * Pointer to new colorop state, or ERR_PTR on failure.
> + */
> +struct drm_colorop_state *
> +drm_atomic_helper_colorop_create_state(struct drm_colorop *colorop)
> +{
> +	struct drm_colorop_state *state;
> +
> +	state = kzalloc_obj(*state);
> +	if (!state)
> +		return ERR_PTR(-ENOMEM);
> +
> +	__drm_colorop_state_init(state, colorop);
> +
> +	return state;
> +}
> +

Is this missing an EXPORT_SYMBOL() declaration?

Modular drivers like amdgpu or vkms wouldn't be able to link and use this
new helper without it.

[ ... ]

> diff --git a/include/drm/drm_colorop.h b/include/drm/drm_colorop.h
> index c873199c60da9..b4b9e4f558ab1 100644
> --- a/include/drm/drm_colorop.h
> +++ b/include/drm/drm_colorop.h
> @@ -425,6 +425,8 @@ int drm_plane_colorop_3dlut_init(struct drm_device *dev, struct drm_colorop *col
>  				 enum drm_colorop_lut3d_interpolation_type interpolation,
>  				 uint32_t flags);
>  
> +struct drm_colorop_state *
> +drm_atomic_helper_colorop_create_state(struct drm_colorop *colorop);

Does struct drm_colorop_funcs also need to be updated to include an
atomic_create_state() function pointer?

Without adding the hook, it seems drivers cannot assign the new helper and
the DRM core would have no way to invoke it.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519-drm-mode-config-init-v5-0-388b03321e38@kernel.org?part=7