Re: [PATCH v3 6/9] power: sequencing: Add an API to return the pwrseq device's 'dev' pointer

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing kernel-doc comment explaining the lifetime of the device pointer returned by pwrseq_to_device().
--

commit d29f3508bf71a5cf1f39e83cf08db650ff869721
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

power: sequencing: Add an API to return the pwrseq device's 'dev' pointer

This commit adds an API to return the pwrseq device's dev pointer to
consumers, allowing them to query the provider's DT node.

> diff --git a/drivers/power/sequencing/core.c b/drivers/power/sequencing/core.c
> index 4dff71be11b60..96ad557297f5b 100644
> --- a/drivers/power/sequencing/core.c
> +++ b/drivers/power/sequencing/core.c
> @@ -965,6 +965,15 @@ int pwrseq_power_off(struct pwrseq_desc *desc)
>  }
>  EXPORT_SYMBOL_GPL(pwrseq_power_off);
>  
> +struct device *pwrseq_to_device(struct pwrseq_desc *desc)

This isn't a bug, but would it be useful to add a kernel-doc comment here
explaining the lifetime of the returned device pointer?

Since this function returns a non-refcounted pointer to the provider's struct
device, its lifetime is tied strictly to the pwrseq_desc object.

> +{
> +	if (!desc)
> +		return NULL;
> +
> +	return &desc->pwrseq->dev;
> +}
> +EXPORT_SYMBOL_GPL(pwrseq_to_device);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519-pwrseq-m2-bt-v3-0-b39dc2ae3966@oss.qualcomm.com?part=6