All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Will Mortensen <will@extrahop.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
	Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
	netdev <netdev@vger.kernel.org>,
	Shahar Shitrit <shshitrit@nvidia.com>,
	Carolina Jubran <cjubran@nvidia.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	linux-rdma <linux-rdma@vger.kernel.org>,
	Jeremy Royal <jeremyr@extrahop.com>
Subject: Re: [PATCH net v3] net/mlx5: don't printk garbage when transceiver overheats
Date: Tue, 19 May 2026 16:59:53 +0300	[thread overview]
Message-ID: <20260519135953.GX33515@unreal> (raw)
In-Reply-To: <CAMpnoC5ACdKiqy9mzmwvm592fJCbxXJCsuFxKJPG0c75_frFhg@mail.gmail.com>

On Tue, May 19, 2026 at 12:35:27AM -0700, Will Mortensen wrote:
> On Mon, May 18, 2026 at 4:26 AM Leon Romanovsky <leon@kernel.org> wrote:
> > Honestly, this approach feels overly complex and fragile for something as
> > simple as printing to dmesg. In my opinion, you should drop
> > print_sensor_names_in_bit_set().
> 
> Do you mean basically revert 46fd50cfcc12 ("net/mlx5: Add sensor name
> to temperature event message")? Yes, we could do that. It is
> definitely fragile regardless; there are lots of assumptions that
> there's at most one ASIC sensor and one module sensor. If we want to
> keep the printing, we could simplify by having temp_warn() just print
> a static string like "ASIC" or "Module" rather than using the strings
> from the firmware, and maybe also call a function in hwmon.c to check
> against our module's sensor index in order to ignore events about
> other modules.

Yes

Thanks

      reply	other threads:[~2026-05-19 13:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-16  6:10 [PATCH net v3] net/mlx5: don't printk garbage when transceiver overheats Will Mortensen
2026-05-18 11:25 ` Leon Romanovsky
2026-05-19  7:35   ` Will Mortensen
2026-05-19 13:59     ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260519135953.GX33515@unreal \
    --to=leon@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=cjubran@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jeremyr@extrahop.com \
    --cc=kuba@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=shshitrit@nvidia.com \
    --cc=tariqt@nvidia.com \
    --cc=will@extrahop.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.