From: Jakub Kicinski <kuba@kernel.org>
To: 최유호 <dbgh9129@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ipv6: route: Unregister netdevice notifier on BPF init failure
Date: Tue, 19 May 2026 16:31:47 -0700 [thread overview]
Message-ID: <20260519163147.300e0520@kernel.org> (raw)
In-Reply-To: <CACrCO_WK+gRhfCr8e8GvXJGqdHA9dO7xQ4fCynrufFmcLrYJ6g@mail.gmail.com>
On Tue, 19 May 2026 09:49:04 -0400 최유호 wrote:
> Thanks for pointing out the outdated tree. I will definitely rebase
> and resubmit v3 against netdev/net.git.
>
> Regarding the goto: The reason I moved away from the goto approach in
> v2 is that if CONFIG_BPF_SYSCALL and CONFIG_PROC_FS are disabled, the
> goto statement is compiled out. This leaves the target label unused,
> triggering an "unused-label" compiler warning.
>
> Since guarding labels with #ifdefs can get messy, I opted for the
> direct unregistration in the failure path for v2 to keep it clean.
>
> Would you still prefer I use the goto and guard the label
> appropriately in v3, or is direct unregistration acceptable given the
> warning?
Yes, guard the label, please.
Reminder: please don't top post.
prev parent reply other threads:[~2026-05-19 23:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 13:05 [PATCH v2] ipv6: route: Unregister netdevice notifier on BPF init failure Yuho Choi
2026-05-19 0:14 ` Jakub Kicinski
2026-05-19 13:49 ` 최유호
2026-05-19 23:31 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519163147.300e0520@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dbgh9129@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.