From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6347B2F8E90 for ; Tue, 19 May 2026 16:46:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779209177; cv=none; b=aclCyOmIo6EvXWZ1c+RzWBPQnml/ehEYzEgJFP47sho2bxkcqLho7EGvuj7kZkVqv1Gozwd44N3KbaG6ImvUruv6mUSPPpoLFjqlQP6eDPMtqke//bSVfYqvzsFRlThQ55gZkpOyX0dtxRr90CWPYcMMDrCyEwrcT8vPeoq2wg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779209177; c=relaxed/simple; bh=dO2JC3cGrgBEiqGi/7DfAV5UDja+Zq6nrt24/gnAyXw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=npruzpjmHF/NzC5yuB74UjKImE3fgUks4fU/c9NAqD7KTAW3+NnSJE+apuFAYoLM6hM5EdVOZrHtKS98371EHrjzNLRQhjDg6rUU3KfACEgyY6SdBtGahgm6gmDGW4Yk3OAMBJht4yh3Ml3dgCYOFr8cqNwefIJdm6JkVWKnTtI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=J/NvsH0U; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="J/NvsH0U" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1779209172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=YX78u8QRoKhhNZEM8bcwTz+5TaYPdqXGSS057AJTrCY=; b=J/NvsH0UhIhABq6lvVVyjxlPaCMLOgLnNxnT88d6EOH5epnl8u+sBF5fiu2+TXtM0mC+8R AEoz1yWUfPEnEobukhYV1H+11S5WyRDkk93HZfLk9Vk1130CArrLtdfGngKjlcA995Fpuu hgtiSgIt6vP4trkoO83IXFK/S71EtP8= From: Thorsten Blum To: Mikulas Patocka Cc: Thorsten Blum , linux-kernel@vger.kernel.org Subject: [PATCH 1/3] fs: hpfs: remove commented out code in hpfs_set_ea Date: Tue, 19 May 2026 18:45:10 +0200 Message-ID: <20260519164509.180686-4-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2158; i=thorsten.blum@linux.dev; h=from:subject; bh=dO2JC3cGrgBEiqGi/7DfAV5UDja+Zq6nrt24/gnAyXw=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDFk8k6cWPYm6bGS33uW/7z7rsrx5M44enRscYGd+9fk16 8iGqzHeHaUsDGJcDLJiiiwPZv2Y4VtaU7nJJGInzBxWJpAhDFycAjCRxTGMDNs7DHestJJx2P1s 2etlBTuL7ZeIfT7am2TLZ5OZ+zFujzEjQ/+1xD/36peteXn22LrYBV/mVC1h8mdbab3pWjlPVNX 2QH4A X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT The code has been commented out ever since commit 1da177e4c3f4 ("Linux-2.6.12-rc2") - remove it. Signed-off-by: Thorsten Blum --- fs/hpfs/ea.c | 26 +------------------------- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/fs/hpfs/ea.c b/fs/hpfs/ea.c index 4664f9ab06ee..3f0213486c21 100644 --- a/fs/hpfs/ea.c +++ b/fs/hpfs/ea.c @@ -236,14 +236,8 @@ void hpfs_set_ea(struct inode *inode, struct fnode *fnode, const char *key, } pos += ea->namelen + ea_valuelen(ea) + 5; } - if (!le16_to_cpu(fnode->ea_offs)) { - /*if (le16_to_cpu(fnode->ea_size_s)) { - hpfs_error(s, "fnode %08x: ea_size_s == %03x, ea_offs == 0", - inode->i_ino, le16_to_cpu(fnode->ea_size_s)); - return; - }*/ + if (!le16_to_cpu(fnode->ea_offs)) fnode->ea_offs = cpu_to_le16(0xc4); - } if (le16_to_cpu(fnode->ea_offs) < 0xc4 || le16_to_cpu(fnode->ea_offs) + le16_to_cpu(fnode->acl_size_s) + le16_to_cpu(fnode->ea_size_s) > 0x200) { hpfs_error(s, "fnode %08llx: ea_offs == %03x, ea_size_s == %03x", inode->i_ino, @@ -295,24 +289,6 @@ void hpfs_set_ea(struct inode *inode, struct fnode *fnode, const char *key, if (hpfs_alloc_if_possible(s, le32_to_cpu(fnode->ea_secno) + len)) { len++; } else { - /* Aargh... don't know how to create ea anodes :-( */ - /*struct buffer_head *bh; - struct anode *anode; - anode_secno a_s; - if (!(anode = hpfs_alloc_anode(s, fno, &a_s, &bh))) - goto bail; - anode->up = cpu_to_le32(fno); - anode->btree.fnode_parent = 1; - anode->btree.n_free_nodes--; - anode->btree.n_used_nodes++; - anode->btree.first_free = cpu_to_le16(le16_to_cpu(anode->btree.first_free) + 12); - anode->u.external[0].disk_secno = cpu_to_le32(le32_to_cpu(fnode->ea_secno)); - anode->u.external[0].file_secno = cpu_to_le32(0); - anode->u.external[0].length = cpu_to_le32(len); - mark_buffer_dirty(bh); - brelse(bh); - fnode->flags |= FNODE_anode; - fnode->ea_secno = cpu_to_le32(a_s);*/ secno new_sec; int i; if (!(new_sec = hpfs_alloc_sector(s, fno, 1, 1 - ((pos + 511) >> 9))))